This is a call I forgot to remove when the new updates code
went in (r333). There were no functional changes due to this,
but slowed down the updates by a perceivable amount.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
This patch touches almost every part of sbopkg, making
it more readable, manageable and less bug-prone.
Working on this already let us spot several bugs, and
will ease further development and debugging efforts.
This is the result of a lot of patient team work, for
which Chess, slakmagik and I should be equally credited.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
This patch refactors the renames code putting the old/new
name retrieval in two generic helpers.
Also fix the upgrading of renamed packages by providing
the old package name to upgradepkg.
Thanks to Phillip Warner for raising the issue, and to
Chess Griffin and slakmagik for testing and reviewing this
patch.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
Add the wbxml2 -> libwbxml rename to the sbopkg-renames
file, as pointed out by Chess Griffin.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
Remove some useless code from check_for_latest(), and
fix the reported download folder.
Thanks to David Somero for reporting and fixing the
bogus printout.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
If the user just saved a queue, or loaded a previously
saved one, there's no need to prompt him for saving it.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
Make the workaround less CPU-hungry and also enable it
for screen sessions.
Thanks to Phillip Warner for the extensive feedback, and
to slakmagik for suggesting the use of 'pgrep'.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
Work around dialogs non being drawn on rxvt-based
terminals unless the user resizes the window.
Thanks to Phillip Warner for raising the issue.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
Some CLI switches (-d, -f and -v) make sense even when
starting the GUI version of sbopkg.
Allow the usage of these flags also when starting the dialog
version of sbopkg.
Thanks to Patzy for raising the issue on #sbopkg and to
Chess Griffin for pointing out a weakness of the first version
of the patch.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
Rework source management to reduce code replication
and make the whole think more robust and powerful.
Functional side-effects of this rework include:
- a checklist is used to show sources, allowing
selective removals
- md5sums are computed only at download time, not
every time a package is built
- a new "search obsolete sources" function pointing
out old sources present in the cache directory
Many thanks to Chess Griffin and slakmagik for their
help in cleaning up this work, testing and bug fixing.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
Fix view_app_file() to use $FILE (its private variable)
instead of $F (the caller's variable which happened to
have the same value). This was a leftover of the
app_files_chooser() split in r450.
Huge thanks are again due to slakmagik for pointing out
this bug.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
