Commit graph

20 commits

Author SHA1 Message Date
gwenhael
deb6e376ce
Merge pull request #5 from h3xx/fix-shellcheck
Fix complaints from shellcheck
2023-07-29 20:02:49 +02:00
Dan Church
b9cbdbad36
Fix complaints from shellcheck
List of complaints fixed:

In npm2tgz line 45:
if [ "x$1" == "x" ] || [ "x$1" == "x--help" ] || [ "x$1" == "x-h" ]; then
     ^---^ SC2268 (style): Avoid x-prefix in comparisons as it no longer serves a purpose.
           ^-- SC3014 (warning): In POSIX sh, == in place of = is undefined.
                         ^---^ SC2268 (style): Avoid x-prefix in comparisons as it no longer serves a purpose.
                               ^-- SC3014 (warning): In POSIX sh, == in place of = is undefined.
                                                   ^---^ SC2268 (style): Avoid x-prefix in comparisons as it no longer serves a purpose.
                                                         ^-- SC3014 (warning): In POSIX sh, == in place of = is undefined.

Did you mean:
if [ "$1" == "" ] || [ "$1" == "--help" ] || [ "$1" == "-h" ]; then

In npm2tgz line 98:
cd "$PKG"
^-------^ SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

Did you mean:
cd "$PKG" || exit

For more information:
  https://www.shellcheck.net/wiki/SC2164 -- Use 'cd ... || exit' or 'cd ... |...
  https://www.shellcheck.net/wiki/SC3014 -- In POSIX sh, == in place of = is ...
  https://www.shellcheck.net/wiki/SC2268 -- Avoid x-prefix in comparisons as ...
2023-07-29 11:42:16 -05:00
gwenhael
bdc3da32ee
Merge pull request #4 from h3xx/fix-quoting
Fix variable quoting issues
2022-07-22 18:23:54 +02:00
Dan Church
3546fb6bda
Fix variable quoting issues
Prevents unintentional whitespace splitting.
2022-07-22 10:55:57 -05:00
Gwenhael Le Moine
8e9926cf02
Fix package name when given specific version, fix #2 2018-12-20 22:27:08 +01:00
Gwenhael Le Moine
1d7319ae06
differentiate node package name from slackware package name as strange
things like @angular/cli appear
2017-09-20 12:18:18 +02:00
Gwenhael Le Moine
b8db5e74f4
Merge branch 'master' of github.com:gwenhael-le-moine/npm2tgz 2017-09-20 12:17:44 +02:00
gwenhael
cd955d9277
Merge pull request #1 from TJ09/master
Fix trailing comma in parsed version numbers. (feat. TJ09)
2017-09-20 12:17:34 +02:00
gwenhael
537e3a546e Merge pull request #1 from TJ09/master
Fix trailing comma in parsed version numbers. (feat. TJ09)
2016-10-15 08:24:11 +02:00
T.J. L
3350993e35 Fix trailing comma in parsed version numbers. 2016-10-14 15:47:14 -07:00
Gwenhael Le Moine
6c9e294d8c thourough
Signed-off-by: Gwenhael Le Moine <gwenhael.le.moine@gmail.com>
2016-01-12 11:01:49 +01:00
Gwenhael Le Moine
11c36da14c version can be on the last line
Signed-off-by: Gwenhael Le Moine <gwenhael.le.moine@gmail.com>
2016-01-12 10:59:19 +01:00
Gwenhael Le Moine
237b695fc1 typo, missing $ 2014-10-27 11:42:20 +01:00
Gwenhael Le Moine
b7665b2df1 get installation path from $()npm root) 2014-10-27 11:40:37 +01:00
Gwenhael Le Moine
af78d38375 whitespaces 2014-10-27 11:40:05 +01:00
Gwenhael Le Moine
4d45faf724 renamed because github ruined the formatting
Signed-off-by: Gwenhael Le Moine <gwenhael.le.moine@gmail.com>
2013-04-01 23:34:16 +02:00
Gwenhael Le Moine
58e8769f43 update README.md
Signed-off-by: Gwenhael Le Moine <gwenhael.le.moine@gmail.com>
2013-04-01 23:09:48 +02:00
Gwenhael Le Moine
3d1cb05018 thought it was managed when it wasn't 2013-04-01 23:06:22 +02:00
Gwenhael Le Moine
3f333de5a5 forgot about package description 2013-04-01 23:05:21 +02:00
Gwenhael Le Moine
c2e3780e4f first commit 2013-04-01 22:51:22 +02:00