I believe this is what we intended, and it is what I want. It could lead to duplicating low-level API in high-level API at first, but once we start seeing DisplayID in the wild, the high-level functions need to start looking into both EDID and DisplayID APIs to deliver the desired information. Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
2.8 KiB
libdisplay-info
EDID and DisplayID library.
Goals:
- Provide a set of high-level, easy-to-use, opinionated functions as well as low-level functions to access detailed information.
- Simplicity and correctness over performance and resource usage.
- Well-tested and fuzzed.
Documentation is available on the website.
Using
The public API headers are categorised as either high-level or low-level API as per the comments in the header files. Users of libdisplay-info should prefer high-level API over low-level API when possible.
If high-level API lacks needed features, please propose additions to the high-level API upstream before using low-level API to get what you need. If the additions are rejected, you are welcome to use the low-level API.
This policy is aimed to propagate best practises when interpreting EDID and DisplayID information which can often be cryptic or even inconsistent.
Contributing
Open issues and merge requests on the GitLab project.
In general, the Wayland contribution guidelines should be followed. In particular, each commit must carry a Signed-off-by tag to denote that the submitter adheres to the Developer Certificate of Origin 1.1. This project follows the freedesktop.org Contributor Covenant.
Building
libdisplay-info is built using Meson. It has no dependencies.
meson setup build/
ninja -C build/
Testing
The low-level EDID library is tested against edid-decode. test/data/
contains a small collection of EDID blobs and diffs between upstream
edid-decode
and our di-edid-decode
clone. Our CI ensures the diffs are
up-to-date. A patch should never make the diffs grow larger. To add a new EDID
blob or update a diff, use test/edid-decode-diff.sh test/data/<edid>
.
To run the test suite locally, you need to use edid-decode of the git
revision mentioned in .gitlab-ci.yml
. Otherwise you may experience false
failures.
The latest code coverage report is available on GitLab CI.
Fuzzing
To fuzz libdisplay-info with AFL, the library needs to be instrumented:
CC=afl-gcc meson build/
ninja -C build/
afl-fuzz -i test/data/ -o afl/ build/di-edid-decode