From e1192b1bb38a6a8906fd42a2f07cf677323c2335 Mon Sep 17 00:00:00 2001
From: coletdjnz <coletdjnz@protonmail.com>
Date: Mon, 3 Jun 2024 11:38:06 +1200
Subject: [PATCH] initialize fake logger

---
 test/conftest.py               | 2 +-
 yt_dlp/networking/_requests.py | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/test/conftest.py b/test/conftest.py
index decd2c85c..6846da90e 100644
--- a/test/conftest.py
+++ b/test/conftest.py
@@ -23,7 +23,7 @@ def handler(request):
         RH_KEY = handler.RH_KEY
 
         def __init__(self, *args, **kwargs):
-            super().__init__(logger=FakeLogger, *args, **kwargs)
+            super().__init__(logger=FakeLogger(), *args, **kwargs)
 
     return HandlerWrapper
 
diff --git a/yt_dlp/networking/_requests.py b/yt_dlp/networking/_requests.py
index e3edc77f3..798885eff 100644
--- a/yt_dlp/networking/_requests.py
+++ b/yt_dlp/networking/_requests.py
@@ -232,14 +232,14 @@ class Urllib3LoggingHandler(logging.Handler):
     def emit(self, record):
         try:
             msg = self.format(record)
+        except Exception:
+            self.handleError(record)
+        else:
             if record.levelno >= logging.ERROR:
                 self._logger.error(msg)
             else:
                 self._logger.stdout(msg)
 
-        except Exception:
-            self.handleError(record)
-
 
 @register_rh
 class RequestsRH(RequestHandler, InstanceStoreMixin):