mirror of
git://xwords.git.sourceforge.net/gitroot/xwords/xwords
synced 2025-01-08 05:24:39 +01:00
cbb683fc74
As reported to google, dict iterator destruction was crashing due to a race condition if it happened after a game using the same dict had been closed since it needed a mapped env that the game closure would remove. Fixed in two ways, one by adding the mapping prior to the code that uses it (a common pattern: add happens many times, whenver it might be needed, but remove only once), and second by passing env into the code that was crashing. The mapping stuff remains inherently racy and I'm not sure now how to fix that. It depends on there being a place to unmap after which it's guaranteed the mapped value won't be needed again. When two objects (game and dict_iter in this case) map the same env/thread combo there's a race. |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| anddict.c | ||
| anddict.h | ||
| andglobals.h | ||
| Android.mk | ||
| andutils.c | ||
| andutils.h | ||
| drawwrapper.c | ||
| drawwrapper.h | ||
| jniutlswrapper.c | ||
| jniutlswrapper.h | ||
| LocalizedStrIncludes.h | ||
| paths.h | ||
| utils.c | ||
| utilwrapper.c | ||
| utilwrapper.h | ||
| xportwrapper.c | ||
| xportwrapper.h | ||
| xptypes.h | ||
| xwjni.c | ||