Andy2
379e5f1d96
use actual rather than max possible board dimensions to apportion
...
space, fixing crashes when max upped to 32. Will still fail as actual
size approaches that number.
2011-11-14 20:18:09 -08:00
Andy2
86d5778ec3
remove 16x16 limitation on board size, replacing with 32x32. Change
...
is enabled by a compile-time flag so Android needn't follow yet.
2011-11-14 18:21:41 -08:00
Eric House
d6fecaa3d3
don't crash when dict is empty file
2011-11-13 17:06:57 -08:00
Andy2
4edca4ee4c
Check for null return from getInfo(), the result when it tries to open
...
a corrupt dict. Such dicts should never get this far, but it doesn't
hurt to be safe.
2011-11-11 18:30:53 -08:00
Andy2
44c5500ab0
don't crash when empty or corrupt dict file passed in.
2011-11-11 18:29:26 -08:00
Andy2
b334e688bb
use getInfo to run sanity check on .xwd files in download directory.
...
This prevents deliberately corrupted files from making it into dict
lists. To the extent that checkSanity() works, it should make use of
that dir safe.
2011-11-11 07:45:25 -08:00
Andy2
9ff4596667
fix compile warning by passing ptr to embedded super
2011-11-11 07:42:00 -08:00
Andy2
92eb6b857d
allow null info ptr so getInfo can be used solely to run sanity check
...
on dict.
2011-11-11 07:41:31 -08:00
Andy2
dddec50f1d
Merge branch 'android_branch' into android_browsedict
...
Conflicts:
xwords4/android/XWords4/jni/Android.mk
xwords4/linux/Makefile
xwords4/linux/linuxmain.c
2011-11-10 19:22:57 -08:00
eehouse@eehouse.org
e48ed847df
Merge remote branch 'origin/android_branch' into android_branch
2011-11-10 19:02:57 -08:00
Andy2
284bd2d0c4
turn on sanity checking of dicts in download directory, but from
...
DictLangCache rather than when the directory's walked initially. Need
to test still with bogus dict and make sure it's never shown.
2011-11-10 19:02:18 -08:00
Eric House
5be5e9fdeb
cleanup script output
2011-11-10 18:39:35 -08:00
Eric House
619c25ee49
add a bit of logging to help deciphering test app problems.
2011-11-10 18:28:11 -08:00
Eric House
cee738942e
back out earlier change using redo: it was broken. Add assert to
...
catch problem with passing ptr to tiles as src of tiles.
2011-11-10 18:26:32 -08:00
Eric House
6d98631640
sanity check: make sure tiles are within range.
2011-11-10 18:24:45 -08:00
eehouse@eehouse.org
9f22b11f81
Merge remote branch 'origin/android_branch' into android_branch
2011-11-10 06:54:42 -08:00
Andy2
43a79a0b47
use undo/redo rather than copying stack to figure past move score.
...
This may have been contributing to crashes, but the new code's more
effecient anyway.
2011-11-10 06:52:33 -08:00
Andy2
00f743409a
script for reproducing problem with relay games that show up randomly.
2011-11-10 06:51:30 -08:00
Andy2
d479b2b979
use timeout rather than idle. Sometimes (due to bug?) curses app is
...
too busy ever to fire idle proc.
2011-11-10 06:51:05 -08:00
Andy2
645695e358
improve logging, and fix mistyped variable found by inspection rather
...
because of a problem.
2011-11-10 06:41:07 -08:00
Andy2
b9a7574925
fix emacs header comments; no code change
2011-11-10 06:39:36 -08:00
Andy2
af5c8a096f
don't pass a pointer to a tray inside the model to model code that
...
will modify that tray! Fixes nasty random crash/assertion failure.
2011-11-10 06:35:05 -08:00
Eric House
36c267ad88
Merge remote branch 'origin/android_branch' into android_branch
2011-11-09 06:52:32 -08:00
Eric House
268f018140
add dict sanity check that will, I hope, catch corrupt dicts.
2011-11-09 06:51:12 -08:00
eehouse@eehouse.org
ffd6a42c1e
Merge remote branch 'origin/android_branch' into android_branch
2011-11-08 21:12:47 -08:00
Eric House
c591182d6c
Modify linux bonus square code to work with board data that's half the
...
size. Toward a board small enough to be transmitted as part of
network game initialization.
2011-11-08 21:11:06 -08:00
Andy2
956fe350ba
remove changed param -- mmap's the default now.
2011-11-07 18:19:12 -08:00
Andy2
e4aa2ff180
finish changelog
2011-11-07 06:51:27 -08:00
Andy2
995c410b7c
revert unintended checkin: logging should not always be on.
2011-11-07 06:49:55 -08:00
Andy2
4b5a06fe20
test code tweaks
2011-11-05 06:14:46 -07:00
Andy2
3707e7aaca
tweak to get performance to same level as before length-filtering was
...
added, mostly by using local variables instead of ptr-accessed in
struct and macro magic to support that. Passes every test I can think
of on Linux but fast-scrolling broken on Android.
2011-11-05 06:14:35 -07:00
eehouse@eehouse.org
214f8990bf
Merge branch 'android_branch' into android_browsedict
2011-11-04 17:23:27 -07:00
Andy2
ac875894a6
replace assert that occasionally fails with logging. Not sure why it
...
fails, but I just drop the (timer) event in the non-debug case so it's
probably harmless.
2011-11-04 17:19:50 -07:00
Andy2
5123bebe50
don't set dict name to "download more". Just not a good idea.
2011-11-04 17:15:12 -07:00
Andy2
0561ca5ab9
make buttons a bit wider since the bar scrolls now, and rearrange.
2011-11-04 17:14:37 -07:00
Andy2
223d2d6e92
set configchanges on chat activity -- it handles orientations changes fine.
2011-11-04 07:11:34 -07:00
eehouse@eehouse.org
71b09b80ab
Merge remote branch 'origin/android_branch' into android_branch
2011-11-04 07:05:56 -07:00
eehouse@eehouse.org
6c1b0e9b58
Merge branch 'android_branch' into android_browsedict
2011-11-04 07:05:16 -07:00
Andy2
61681745c2
sort languages (groups) in dicts activity alphabetically
2011-11-04 07:03:40 -07:00
Andy2
57a1069efe
wire min/max through jni: now selecting numbers changes the number and
...
length of words selected. But it's really slow, and indexing seems
broken in some cases. Not ready for release yet.
2011-11-04 06:56:59 -07:00
Andy2
fa14f02b69
add ui support for min,max filtering of wordlist. Not yet wired into
...
jni. But: even disabled it seems to lead to much slower scrolling, so
I need to investigate that before taking this any further.
2011-11-04 06:18:11 -07:00
Andy2
1bba95a985
add minmax compile-time flag, commented-out
2011-11-04 06:17:09 -07:00
Andy2
da02e994b7
protext min,max with compile-time flag
2011-11-04 06:16:44 -07:00
Andy2
4e66747bbc
fix for changed API
2011-11-03 21:35:17 -07:00
Eric House
adb9473a87
Merge branch 'android_branch' into android_browsedict
...
Conflicts:
xwords4/common/dictiter.c
xwords4/linux/linuxmain.c
2011-11-03 21:32:04 -07:00
Eric House
30387bc528
up version codes
2011-11-03 21:27:43 -07:00
Eric House
a2319a8073
experimental additions, mostly compile-time disable-able, so prune
...
dict by wordlen.
2011-11-03 21:25:51 -07:00
Andy2
948def8223
replace burried launch-dict-browser menuitem with toolbar button and
...
newbie hint.
2011-11-03 18:14:01 -07:00
Andy2
8db6b0bddd
wrap toolbar in a HorizontalScrollView. Comes into action when all
...
buttons are enabled.
2011-11-03 17:24:56 -07:00
Andy2
1de9f806e9
test dict_countWords()
2011-11-03 06:19:07 -07:00
Andy2
627410250f
reuse existing code in dict_countWords()
2011-11-03 06:18:53 -07:00
Andy2
4f29f51253
turn dict iter feature on for linux for good
2011-11-03 06:18:15 -07:00
Andy2
d19858d6bb
add (buried) menuitem to launch dict browser from game. Required
...
adding method to get current player from BoardView.
2011-11-03 05:51:38 -07:00
Andy2
6e58963231
sign up to handle keyboard/orientation changes for dict browser
2011-11-03 05:32:36 -07:00
Andy2
eace89000b
save text size rather than figure each time
2011-11-03 05:20:38 -07:00
Andy2
a5498ee33a
fix find to return position rather than boolean
2011-11-03 05:20:11 -07:00
Andy2
56fc73e78a
don't go straight from tap on dict word to browser: add bool so that
...
even if there's only one lookup URL it'll be listed and user can
quickly cancel.
2011-11-02 18:48:13 -07:00
Andy2
c222f08252
catch up with API changes.
2011-11-02 18:46:06 -07:00
eehouse@eehouse.org
ae118e78a3
Merge branch 'android_branch' into android_browsedict
2011-11-02 18:32:26 -07:00
Andy2
5c995af38c
stop changing formats between internal and external structs
...
(iterators); use internal format all the time for speed. Update linux
test code for new API.
2011-11-02 18:32:00 -07:00
Andy2
7231bd4be3
make dict entries text size bigger
2011-11-02 05:18:10 -07:00
Andy2
8704acfbf1
launch dict browser from tap on dict rather than contextual menu on it.
2011-11-02 05:06:53 -07:00
Andy2
050a68ce42
use XP_REALLOC now that it's fixes
2011-11-02 05:04:31 -07:00
eehouse@eehouse.org
04b8c09128
Merge branch 'android_branch' into android_browsedict
2011-11-02 04:39:51 -07:00
Andy2
ab4ccb1a22
use realloc for testing
2011-11-02 04:39:12 -07:00
Andy2
38867b2875
fix bug in debug free following debug realloc to smaller size
2011-11-02 04:38:39 -07:00
Andy2
eb2b139e48
add some consts and better test for null index data
2011-11-01 18:47:20 -07:00
Andy2
b822f573d6
use getStartsWith() to implement search; add dict name and word count to
...
title; change text of menu item that launches dict browser from
Details to Browse
2011-11-01 18:45:41 -07:00
Andy2
9f2158f094
add dict_getStartsWith to jni
2011-11-01 18:43:36 -07:00
Andy2
482aca5cfb
fix crash due to bad allocation of indexing data space. First cut
...
used XP_REALLOC, but that turns out to be broken, at least on android.
Haven't really used it before...
2011-11-01 18:33:29 -07:00
Andy2
5827127ceb
add some consts and better test for null index data
2011-11-01 18:18:06 -07:00
Andy2
fc4a5c31f4
silence picky compiler
2011-10-31 21:11:52 -07:00
Andy2
11b7ed1e8e
fix to compile with new dictiter files
2011-10-31 21:11:22 -07:00
Andy2
3b04cb542c
silence picky compiler
2011-10-31 21:11:10 -07:00
eehouse@eehouse.org
45de6c734b
Merge branch 'android_branch' into android_browsedict
2011-10-31 21:06:04 -07:00
Andy2
0d4404d43b
add dict_getStartsWith(), and code to test it. Lots of cleanup and
...
bugfixing of dictiter code as well.
2011-10-31 21:05:34 -07:00
Andy2
88f556356c
dict_tileForString -> dict_tilesForString
2011-10-31 20:56:48 -07:00
Andy2
69b1b4da27
break dict iteration stuff out into new files. No code change
...
otherwise.
2011-10-31 18:30:55 -07:00
Andy2
3c53da46ce
fix to compile with changed API. Crashes, but want to fix up API in
...
other branch before debugging here....
2011-10-31 18:22:33 -07:00
eehouse@eehouse.org
24d95675c7
Merge branch 'android_branch' into android_browsedict
2011-10-31 07:03:34 -07:00
eehouse@eehouse.org
916d817ef2
Merge remote branch 'origin/android_branch' into android_branch
2011-10-31 07:02:30 -07:00
eehouse@eehouse.org
ff3a8d4179
Merge branch 'android_branch' into android_browsedict
2011-10-31 06:38:16 -07:00
Andy2
1d34c26ebc
remove unneeded parama
2011-10-31 06:37:53 -07:00
Andy2
dc58d123d5
combine params into single struct
2011-10-31 06:34:21 -07:00
Eric House
491c9d06d6
reverse sense of option to mmap dicts by default
2011-10-29 20:31:47 -07:00
Andy2
7d1e9c7638
Merge branch 'android_branch' into android_browsedict
...
Conflicts:
xwords4/android/XWords4/jni/Android.mk
xwords4/android/XWords4/res/values/strings.xml
xwords4/android/XWords4/src/org/eehouse/android/xw4/BoardActivity.java
2011-10-28 22:27:22 -07:00
Andy2
8f3c4f6426
add config option to enable face-up tile picking
2011-10-28 22:24:47 -07:00
Andy2
8d228ae190
turn on face-up tile picking for Android (though there's no prefs UI
...
to enable it for a game yet). In common code, break pick tile utils
method in two, one for blank and the other for tray tiles. In java,
implement dialog for picking the tiles. Works, though is a bit clumsy
to have the dialog come and go after every pick. Better would be a
dialog that stays up and accumulates picks -- but it'd have to know to
reduce the set of tile choices as letters are chosen. This'll do for
now.
2011-10-28 22:15:56 -07:00
Andy2
390e7558b0
Merge branch 'android_branch' into android_browsedict
...
Conflicts:
xwords4/common/dictnry.c
2011-10-28 21:00:01 -07:00
Eric House
f6ff3e85c6
Merge remote branch 'origin/android_branch' into android_branch
...
Conflicts:
xwords4/common/dictnry.c
xwords4/common/dictnry.h
xwords4/linux/linuxmain.c
2011-10-28 20:54:55 -07:00
Eric House
71450b02b3
use indexing (and add binary search) to double speed of getNthWord
2011-10-28 20:27:16 -07:00
Eric House
ff89ffb168
add missing backup button to fully test tile picking
2011-10-28 20:23:59 -07:00
Andy2
4df13f5617
fix missing dict language
2011-10-28 06:39:47 -07:00
Andy2
b490618c8e
silence warning with cast
2011-10-28 06:34:59 -07:00
Eric House
84044fa9ee
move lookup dialog into superclass so can be used from dict browser.
2011-10-27 21:10:35 -07:00
Eric House
308720186d
get all word-click events and print contents -- setting up for lookup
2011-10-27 18:43:28 -07:00
Eric House
1741021c3c
add search field and button. Not yet wired to do anything.
2011-10-27 18:26:48 -07:00
Eric House
ed055b83c6
export index from jni and use for fastscrolling. Works, but is a bit slow still.
2011-10-27 07:01:57 -07:00
Eric House
5282246dd6
use <cr> and previx separator, not terminator, so java-side split() doesn't end list with empty str.
2011-10-27 07:00:57 -07:00
Eric House
4818a2919d
Merge branch 'android_branch' into android_browsedict
2011-10-26 22:25:54 -07:00
Eric House
42d1a48a1d
don't include indices for prefixes that don't exist.
2011-10-26 22:25:21 -07:00
Eric House
412a58f6b9
make dict_makeIndex work for depth > 1.
2011-10-26 22:20:21 -07:00
Eric House
f2c4e39cd4
add dict_makeIndex(). Works, but only for depth==1 so far (A, not AA or AAA).
2011-10-26 07:10:50 -07:00
Andy2
92f692510f
outline for fastscroll with thumb. Will need jin support mapping
...
indices <-> first letters, e.g. BB to whatever the index is of the
first word starting with BB.
2011-10-25 19:33:55 -07:00
Andy2
a7ce5a43de
fix so count comes from dict; combine two jni methods into one; fix
...
crash in destructor. Now an entire dict can be scrolled through if
you have the patience.
2011-10-25 18:36:12 -07:00
eehouse@eehouse.org
57487aaf3e
Merge branch 'android_branch' into android_browsedict
2011-10-25 06:49:32 -07:00
Andy2
b62fe13c97
move dict iterator test into separate function and add test for
...
dict_getNthWord(). Still ifdef'd out.
2011-10-25 06:48:59 -07:00
Andy2
fc973079dc
add first cut at dict_getNthWord. Works. Is slow.
2011-10-25 06:48:16 -07:00
Andy2
74cf751729
use existing dict iteration APIs to implement jni that adequately
...
displays a dict. But I don't have a getNth in C to implement the one
I've added in java; need to add that, and caching, to speed it up.
2011-10-24 20:15:52 -07:00
eehouse@eehouse.org
a75aa88c58
Merge branch 'android_branch' into android_browsedict
2011-10-24 18:27:33 -07:00
Andy2
ac214236c4
add code to walk dict backwards as well, and test code that
...
succesfully walks huge dicts in both directions turning out the same
list of words either way. Still compile-time disabled.
2011-10-24 18:27:16 -07:00
Andy2
b08f9770cf
add dictionary browser. For now it just adds items to the list that
...
give the position so I can get a feel for how it works. Will use this
to figure out the right API for a dictionary iterator.
2011-10-23 19:35:15 -07:00
Andy2
c237717de5
dict_getInfo returns false if the dict doesn't parse so can be used to
...
test validity of downloaded dict. Internally (in jni), add lots of
checks that format is correct and we don't run off end of ptr walking
truncated dict.
2011-10-23 14:21:57 -07:00
Andy2
7c7cd82e0a
add code to iterate over words in a dict. Works on Linux (iterating
...
forward only) but disabled at compile time. Idea's to have a dict
browser. There was some simple refactoring in common code Android
uses, and that tests fine.
2011-10-21 18:51:33 -07:00
Andy2
201c32e4db
add support for download directory as a place where we look for dicts
...
and to/from which dicts can be moved. Right now it's just
/sdcard/download. Dunno if that's universal. There seems not to be
API except in newer SDK versions for finding it.
2011-10-20 20:22:36 -07:00
Andy2
4eee7f8aa7
Pass selected tiles into new util function, and from there into java
...
world, so confirming query can include them.
2011-10-19 18:34:26 -07:00
Andy2
d63f6961d4
fix log comment to correctly identify site.
2011-10-18 21:29:59 -07:00
Andy2
c2a7a5c347
fix crash: don't destroy stream if for some reason it's null. Not
...
sure how that happens, but it does.
2011-10-18 21:29:40 -07:00
Andy2
90b0a4e46f
if words stream is null, don't pass into java code (where current impl
...
will get a NPE)
2011-10-18 21:28:50 -07:00
Andy2
652b7e703a
Remove difference between debug- and non-debug stream format.
2011-10-18 21:27:28 -07:00
Andy2
b31e829414
Remove file-format differences between debug and non-debug versions.
...
Fix curses to compile non-debug.
2011-10-18 18:52:37 -07:00
Andy2
028c416587
don't disable player listing when game is in play and locked; allow
...
users to see info about players and change dict.
2011-10-18 06:46:46 -07:00
Andy2
71fabdac95
add changelist change
2011-10-18 06:35:26 -07:00
Andy2
214debca47
up strings for beta 37
2011-10-18 06:16:15 -07:00
Andy2
ff82c20b2c
fix brokenness (black-on-black text in lookup dialog) on 2.2 and
...
beyond by copying in layout for built-in list items and hard-coding
white text color. This is risky/fragile but I can't find another fix.
2011-10-17 21:33:11 -07:00
Andy2
dc84cfcb97
cleanup/reformat. No code change.
2011-10-17 20:27:51 -07:00
Andy2
235259ef45
a bit more tuning of model_listWordsThrough()...
2011-10-17 18:26:04 -07:00
Andy2
3b7532aba8
improve stack_redo() to return the redone move, and use that to avoid
...
making a copy of the move stack in model_listWordsThrough()
2011-10-17 18:16:19 -07:00
Andy2
9109396ae9
in model_listWordsThrough, only undo as much as needed to find the
...
move tile that places a tile on the cell we're interested in.
2011-10-17 06:48:59 -07:00
Andy2
8062a027e7
cleanup: NULL's a legal value now.
2011-10-17 06:48:13 -07:00
Andy2
b02e0eb9cf
actually list words: makes a better test.
2011-10-17 06:47:49 -07:00
Andy2
29eec38821
remove unused strings
2011-10-16 17:59:00 -07:00
Andy2
6793742f0f
remove option to list all words played in a single lookup dialog, and
...
supporting code in the jni/common C.
2011-10-14 22:32:30 -07:00
Eric House
46392da205
Fix crash when password dialog comes up second time: don't be cute and
...
reuse custom views as they remember their parent and that needs to be
cleared. Just recreate each time and let gc() do its job.
2011-10-14 19:07:19 -07:00
Eric House
851b2d296f
Should have gone with last checkin: delete of file due to renaming.
2011-10-14 19:05:07 -07:00
Eric House
e848b150b5
rename LookupActivity->LookupView since it's not an Activity any more.
2011-10-14 18:45:47 -07:00
Eric House
0b54b190b6
make lookup dialog a mere dialog rather than an activity to fix
...
too-slow transitions to and from it. Works by keeping code in
separate custom view and not setting buttons or anything else on the
dialog.
2011-10-14 18:39:39 -07:00
Andy2
0e6b4d749f
When pen held on committed tile on board, cons up list of all words
...
played that include that tile and pass to new util_cellSquareHeld()
method. In java implementation of that method, use existing lookup
activity code to display list of words. Enabled on the C side by a
compile-time flag in case it has problems. Right now the time spent
saving a game before launching the lookup activity, and reloading it
after, is pretty apparent, but that's in emulator which is slow.
2011-10-13 19:14:08 -07:00
Andy2
7449923328
log tiles left in pool -- makes progress of automated/test games
...
easier to follow.
2011-10-13 19:10:13 -07:00
Andy2
01459285d5
show dict as comment beside player name in players list. And since
...
dicts change when language does, put language choice above players
list.
2011-10-12 18:37:31 -07:00
Andy2
0dfa69b1b2
implement pen timer with timeout, not idle.
2011-10-11 19:38:26 -07:00
Eric House
f86b0dfcc5
fix to compile on x86 (with newer compiler that doesn't like unused variables)
2011-10-10 22:42:02 -07:00
Andy2
9551f29335
up strings for beta 36. I'm skipping b35 rather than try to move the tag.
2011-10-10 22:30:38 -07:00
Andy2
4bb61401bd
fix crash: src and dest stream params were reversed.
2011-10-10 22:24:44 -07:00
Andy2
92a2fb1a1f
attach newbie info to the lookup button
2011-10-10 18:24:06 -07:00
Andy2
cdf57d3bb7
cleanup
2011-10-10 06:53:46 -07:00
Andy2
d5ca5bbd0d
remove misplaced assert: in network games illegal words may well
...
arrive.
2011-10-10 06:48:07 -07:00
Andy2
c3ba50c905
up strings for beta 35
2011-10-07 18:59:32 -07:00
Andy2
03543c17ea
fix NPE I got once, presumably when activity shutting down.
2011-10-07 18:59:17 -07:00
Andy2
f03699f701
add newbie warning/request for languages with only google as
...
word-lookup site.
2011-10-06 19:03:07 -07:00