From e1dbd8efc7951c784fda3e47f97d3cf7f0c56366 Mon Sep 17 00:00:00 2001 From: Eric House Date: Fri, 19 Aug 2016 12:49:30 -0700 Subject: [PATCH] cleanup and add a bit of logging I suspect curThis() is no longer needed so will log it for a while. --- .../XWords4/src/org/eehouse/android/xw4/DelegateBase.java | 4 +++- .../XWords4/src/org/eehouse/android/xw4/FirstRunDialog.java | 6 +++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/xwords4/android/XWords4/src/org/eehouse/android/xw4/DelegateBase.java b/xwords4/android/XWords4/src/org/eehouse/android/xw4/DelegateBase.java index 9c4739d7f..4c26bcf97 100644 --- a/xwords4/android/XWords4/src/org/eehouse/android/xw4/DelegateBase.java +++ b/xwords4/android/XWords4/src/org/eehouse/android/xw4/DelegateBase.java @@ -160,7 +160,9 @@ public class DelegateBase implements DlgClickNotify, if ( null != ref ) { result = ref.get(); } - // DbgUtils.logdf( "%s.curThis() => " + result, this.toString() ); + if ( this != result ) { + DbgUtils.logdf( "%s.curThis() => " + result, this.toString() ); + } return result; } diff --git a/xwords4/android/XWords4/src/org/eehouse/android/xw4/FirstRunDialog.java b/xwords4/android/XWords4/src/org/eehouse/android/xw4/FirstRunDialog.java index fe26f0d72..cc1b7a181 100644 --- a/xwords4/android/XWords4/src/org/eehouse/android/xw4/FirstRunDialog.java +++ b/xwords4/android/XWords4/src/org/eehouse/android/xw4/FirstRunDialog.java @@ -65,12 +65,12 @@ public class FirstRunDialog { view.getSettings().setJavaScriptEnabled( true ); // for surveymonkey view.loadUrl("file:///android_asset/changes.html"); - AlertDialog dialog = LocUtils.makeAlertBuilder( context ) + LocUtils.makeAlertBuilder( context ) .setIcon(android.R.drawable.ic_menu_info_details) .setTitle( R.string.changes_title ) .setView( view ) .setPositiveButton( android.R.string.ok, null) - .create(); - dialog.show(); + .create() + .show(); } }