Miroirs/xwords
1
0
Fork 0
mirror of git://xwords.git.sourceforge.net/gitroot/xwords/xwords synced 2025-01-09 05:24:44 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

open wordlists browser even without Storage permission

Browse source 
and add a na-key to rationale for storage permissions so don't
ask forever when user wants to decline.
This commit is contained in:
Eric House 2020-09-01 12:29:33 -07:00
parent b5bc784431
commit e0d291ae0e
3 changed files with 20 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
xwords4/android/app/src/main/java/org/eehouse/android/xw4/DictsDelegate.java
View file

@ -524,8 +524,9 @@ public class DictsDelegate extends ListDelegateBase
makeNotAgainBuilder( R.string.not_again_dicts, R.string.key_na_dicts ) makeNotAgainBuilder( R.string.not_again_dicts, R.string.key_na_dicts )
.show(); .show();
tryGetPerms( Perm.STORAGE, R.string.dicts_storage_rationale, Perms23.tryGetPermsNA( this, Perm.STORAGE, R.string.dicts_storage_rationale,
Action.STORAGE_CONFIRMED ); R.string.key_na_perms_storage_dicts,
Action.STORAGE_CONFIRMED );
} // init } // init
@Override @Override
@ -944,6 +945,20 @@ public class DictsDelegate extends ListDelegateBase
return handled; return handled;
} }
@Override
public boolean onNegButton( Action action, Object[] params )
{
boolean handled = true;
switch ( action ) {
case STORAGE_CONFIRMED:
mkListAdapter();
break;
default:
handled = super.onNegButton( action, params );
}
return handled;
}
private DictLoc itemToRealLoc( int item ) private DictLoc itemToRealLoc( int item )
{ {
item += DictLoc.INTERNAL.ordinal(); item += DictLoc.INTERNAL.ordinal();

1
xwords4/android/app/src/main/res/values/common_rsrc.xml
View file

@ -154,6 +154,7 @@
<string name="key_na_sms_banned">key_na_sms_banned</string> <string name="key_na_sms_banned">key_na_sms_banned</string>
<string name="key_na_longtap_lookup">key_na_longtap_lookup</string> <string name="key_na_longtap_lookup">key_na_longtap_lookup</string>
<string name="key_na_perms_phonestate">key_na_perms_phonestate</string> <string name="key_na_perms_phonestate">key_na_perms_phonestate</string>
<string name="key_na_perms_storage_dicts">key_na_perms_storage_dicts</string>
<string name="key_na_newFeatureFilter">key_na_newFeatureFilter</string> <string name="key_na_newFeatureFilter">key_na_newFeatureFilter</string>
<string name="key_na_dupstatus_host">key_na_dupstatus_host</string> <string name="key_na_dupstatus_host">key_na_dupstatus_host</string>

4
xwords4/android/app/src/main/res/values/strings.xml
View file

@ -2426,9 +2426,9 @@
still be able to receive invitations if you don’t grant this still be able to receive invitations if you don’t grant this
permission, but only the phone number of the sender will be permission, but only the phone number of the sender will be
displayed. displayed.
</string> </string>
<string name="move_dict_rationale">Storing a wordlist in the <string name="move_dict_rationale">Storing a wordlist in the
Downloads area requires permission.</string> Downloads area requires Storage permission.</string>
<string name="remove_sms">Remove SMS</string> <string name="remove_sms">Remove SMS</string>
<!-- In the permissions rationale explanation, means go ahead and <!-- In the permissions rationale explanation, means go ahead and
have the OS ask for permission --> have the OS ask for permission -->