From ae25c6e0143180dc3a279fca1e8ab73d707e6cfe Mon Sep 17 00:00:00 2001
From: Eric House <xwords@eehouse.org>
Date: Tue, 12 Sep 2017 07:56:40 -0700
Subject: [PATCH] fix list item breakage: no inputType for TextView

I'd added inputType="text" everywhere I added maxLines="1" but it turns
out that breaks touches being handled at least on some devices. And it
makes no sense to have an inputType for something user can't put into.
---
 xwords4/android/app/src/main/res/layout/chat_row.xml         | 2 --
 xwords4/android/app/src/main/res/layout/game_list_item.xml   | 1 -
 xwords4/android/app/src/main/res/layout/list_item.xml        | 2 --
 xwords4/android/app/src/main/res/layout/loc_list_item.xml    | 2 --
 xwords4/android/app/src/main/res/layout/player_list_elem.xml | 2 --
 5 files changed, 9 deletions(-)

diff --git a/xwords4/android/app/src/main/res/layout/chat_row.xml b/xwords4/android/app/src/main/res/layout/chat_row.xml
index b9bce4209..763e624f5 100644
--- a/xwords4/android/app/src/main/res/layout/chat_row.xml
+++ b/xwords4/android/app/src/main/res/layout/chat_row.xml
@@ -6,14 +6,12 @@
             android:textAppearance="?android:attr/textAppearanceMedium"
             android:layout_marginRight="8dp"
             android:maxLines="1"
-            android:inputType="text"
             />
   <TextView android:id="@+id/chat_row_name"
             android:layout_height="wrap_content"
             android:textAppearance="?android:attr/textAppearanceMedium"
             android:layout_marginRight="8dp"
             android:maxLines="1"
-            android:inputType="text"
             />
   <TextView android:id="@+id/chat_row_text"
             android:layout_height="wrap_content"
diff --git a/xwords4/android/app/src/main/res/layout/game_list_item.xml b/xwords4/android/app/src/main/res/layout/game_list_item.xml
index c382c3917..77972e134 100644
--- a/xwords4/android/app/src/main/res/layout/game_list_item.xml
+++ b/xwords4/android/app/src/main/res/layout/game_list_item.xml
@@ -79,7 +79,6 @@
                      android:gravity="center"
                      android:layout_weight="1"
                      android:maxLines="1"
-                     android:inputType="text"
                      android:textAppearance="?android:attr/textAppearanceMedium"
                      />
 
diff --git a/xwords4/android/app/src/main/res/layout/list_item.xml b/xwords4/android/app/src/main/res/layout/list_item.xml
index 63bedfe4f..4aa520d2b 100644
--- a/xwords4/android/app/src/main/res/layout/list_item.xml
+++ b/xwords4/android/app/src/main/res/layout/list_item.xml
@@ -32,7 +32,6 @@
                   android:layout_weight="1"
    	              android:textAppearance="?android:attr/textAppearanceMedium"
                   android:maxLines="1"
-                  android:inputType="text"
                   />
 
         <TextView android:id="@+id/text_item2"
@@ -41,7 +40,6 @@
                   android:layout_weight="1"
                   android:gravity="right"
                   android:maxLines="1"
-                  android:inputType="text"
                   android:visibility="gone"
                   />
 
diff --git a/xwords4/android/app/src/main/res/layout/loc_list_item.xml b/xwords4/android/app/src/main/res/layout/loc_list_item.xml
index 2a918ebc9..48326a1a6 100644
--- a/xwords4/android/app/src/main/res/layout/loc_list_item.xml
+++ b/xwords4/android/app/src/main/res/layout/loc_list_item.xml
@@ -10,12 +10,10 @@
     <TextView android:id="@+id/english_view"
               style="@style/evenly_spaced_horizontal"
               android:maxLines="1"
-              android:inputType="text"
               />
     <TextView android:id="@+id/xlated_view"
               style="@style/evenly_spaced_horizontal"
               android:maxLines="1"
-              android:inputType="text"
               />
 
 </org.eehouse.android.xw4.loc.LocListItem>
diff --git a/xwords4/android/app/src/main/res/layout/player_list_elem.xml b/xwords4/android/app/src/main/res/layout/player_list_elem.xml
index 78600b019..a2092b6d2 100644
--- a/xwords4/android/app/src/main/res/layout/player_list_elem.xml
+++ b/xwords4/android/app/src/main/res/layout/player_list_elem.xml
@@ -10,14 +10,12 @@
             android:layout_width="wrap_content" 
             android:layout_height="wrap_content"
             android:maxLines="1"
-            android:inputType="text"
             android:gravity="left"
             />
   <TextView android:id="@+id/item_score"
             android:layout_width="fill_parent" 
             android:layout_height="wrap_content"
             android:maxLines="1"
-            android:inputType="text"
             android:gravity="right"
             />
 </org.eehouse.android.xw4.ExpiringLinearLayout>