From 37a79b25f6e882e67995b550a7f45b388bd4dc4a Mon Sep 17 00:00:00 2001 From: Eric House Date: Sat, 14 Sep 2013 21:22:06 -0700 Subject: [PATCH 1/3] fix reported NPE (by inspection, as I can't repro) --- .../src/org/eehouse/android/xw4/BoardActivity.java | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/xwords4/android/XWords4/src/org/eehouse/android/xw4/BoardActivity.java b/xwords4/android/XWords4/src/org/eehouse/android/xw4/BoardActivity.java index 38452f001..48fb864f7 100644 --- a/xwords4/android/XWords4/src/org/eehouse/android/xw4/BoardActivity.java +++ b/xwords4/android/XWords4/src/org/eehouse/android/xw4/BoardActivity.java @@ -2081,9 +2081,13 @@ public class BoardActivity extends XWActivity private void setBackgroundColor() { - int back = CommonPrefs.get( this ) - .otherColors[CommonPrefs.COLOR_BACKGRND]; - findViewById(R.id.board_root).setBackgroundColor( back ); + View view = findViewById( R.id.board_root ); + // Google's reported an NPE here, so test + if ( null != view ) { + int back = CommonPrefs.get( this ) + .otherColors[CommonPrefs.COLOR_BACKGRND]; + view.setBackgroundColor( back ); + } } private void setKeepScreenOn() From 59d32d36b0dcdacad1bfdd7a45cbcae30222115f Mon Sep 17 00:00:00 2001 From: Eric House Date: Sun, 15 Sep 2013 10:32:26 -0700 Subject: [PATCH 2/3] up version strings --- xwords4/android/XWords4/AndroidManifest.xml | 2 +- xwords4/android/XWords4/res/raw/changes | 9 ++------- xwords4/android/XWords4/res/values/app_name.xml | 2 +- 3 files changed, 4 insertions(+), 9 deletions(-) diff --git a/xwords4/android/XWords4/AndroidManifest.xml b/xwords4/android/XWords4/AndroidManifest.xml index 0693bd4c7..034c04da5 100644 --- a/xwords4/android/XWords4/AndroidManifest.xml +++ b/xwords4/android/XWords4/AndroidManifest.xml @@ -22,7 +22,7 @@ to come from a domain that you own or have control over. --> diff --git a/xwords4/android/XWords4/res/raw/changes b/xwords4/android/XWords4/res/raw/changes index c64504047..9c8febc83 100644 --- a/xwords4/android/XWords4/res/raw/changes +++ b/xwords4/android/XWords4/res/raw/changes @@ -9,17 +9,12 @@

New with this release

    -
  • Fix menu missing on some tablets
  • - -
  • Disable in-game Chat feature. (It has bugs that cause games to - stop syncing moves. I'll fix eventually. Let me know if you - use this feature and I'll up the priority.)
  • - -
  • Fix crash triggered by resignation
  • +
  • Quick fix: crash (in setBackgroundColor) on some devices

Next up

    +
  • Put chat feature back
  • Improve communication with relay, part 2. (Really, I'm almost done!)
diff --git a/xwords4/android/XWords4/res/values/app_name.xml b/xwords4/android/XWords4/res/values/app_name.xml index a21423989..ea32b7d9a 100644 --- a/xwords4/android/XWords4/res/values/app_name.xml +++ b/xwords4/android/XWords4/res/values/app_name.xml @@ -1,5 +1,5 @@ - 4.4 beta 66 + 4.4 beta 67 From 6225ec1d8758c0a299300cccb5c3f9a55d1ea7ee Mon Sep 17 00:00:00 2001 From: Eric House Date: Sun, 15 Sep 2013 13:12:34 -0700 Subject: [PATCH 3/3] fix name string --- xwords4/android/XWords4/res/raw/changes | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xwords4/android/XWords4/res/raw/changes b/xwords4/android/XWords4/res/raw/changes index 9c8febc83..861adafe5 100644 --- a/xwords4/android/XWords4/res/raw/changes +++ b/xwords4/android/XWords4/res/raw/changes @@ -5,7 +5,7 @@ -Crosswords 4.4 beta 66 release +Crosswords 4.4 beta 67 release

New with this release