Miroirs/xwords
1
0
Fork 0
mirror of git://xwords.git.sourceforge.net/gitroot/xwords/xwords synced 2025-02-07 20:46:17 +01:00
Code Issues Projects Releases Packages Wiki Activity

make game sort order clearer and easier to modify

Browse source 
For the ORDER BY clause that governs how games are displayed within a
group, use a static string built from a list of clauses that are then
easy to move up and down. Add clause that moves games with unread chat
to the top. Another commit will modify the display so it's clear why
it's there.
This commit is contained in:
Eric House 2017-09-02 11:26:10 -07:00
parent 5ed9d2c6aa
commit a10dd6a314
1 changed files with 17 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
xwords4/android/app/src/main/java/org/eehouse/android/xw4/DBUtils.java
View file

@ -1616,25 +1616,34 @@ public class DBUtils {
return result;
}
// ORDER BY clause that governs display of games in main GamesList view
private static final String s_getGroupGamesOrderBy =
TextUtils.join(",", new String[] {
// Ended games at bottom
DBHelper.GAME_OVER,
// games with unread chat messages at top
"(" + DBHelper.HASMSGS + " & " + GameSummary.MSG_FLAGS_CHAT + ") IS NOT 0 DESC",
// Games not yet connected at top
DBHelper.TURN + " is -1 DESC",
// Games where it's a local player's turn at top
DBHelper.TURN_LOCAL + " DESC",
// finally, sort by timestamp of last-made move
DBHelper.LASTMOVE,
});
public static long[] getGroupGames( Context context, long groupID )
{
long[] result = null;
initDB( context );
String[] columns = { ROW_ID };
String[] columns = { ROW_ID, DBHelper.HASMSGS };
String selection = String.format( "%s=%d", DBHelper.GROUPID, groupID );
// Sort unconnected games at top (turn==-1), games that are finished
// at the bottom, then games at the top by how long it's been the
// device owner's turn.
String orderBy = String.format( "%s is -1 DESC,%s,%s DESC,%s", DBHelper.TURN,
DBHelper.GAME_OVER, DBHelper.TURN_LOCAL,
DBHelper.LASTMOVE );
synchronized( s_dbHelper ) {
Cursor cursor = s_db.query( DBHelper.TABLE_NAME_SUM, columns,
selection, // selection
null, // args
null, // groupBy
null, // having
orderBy
s_getGroupGamesOrderBy
);
int index = cursor.getColumnIndex( ROW_ID );
result = new long[ cursor.getCount() ];