From 9dfcb2dda2ea350fa35b985d0e607a1e6331dc00 Mon Sep 17 00:00:00 2001
From: Andy2 <andy2@trand>
Date: Sun, 8 May 2011 22:50:42 -0700
Subject: [PATCH 01/13] first step toward using an expandable list for dicts
 browser, with languages as first-level items each containing all of the
 dictionaries in that language.  This is a snapshot: it's broken visually and
 functionally.

---
 .../XWords4/res/layout/dict_browse.xml        |  10 +-
 .../eehouse/android/xw4/DictLangCache.java    |   6 +-
 .../eehouse/android/xw4/DictsActivity.java    | 141 ++++++++++++++----
 3 files changed, 124 insertions(+), 33 deletions(-)

diff --git a/xwords4/android/XWords4/res/layout/dict_browse.xml b/xwords4/android/XWords4/res/layout/dict_browse.xml
index e3c652fdc..72f9de8cf 100644
--- a/xwords4/android/XWords4/res/layout/dict_browse.xml
+++ b/xwords4/android/XWords4/res/layout/dict_browse.xml
@@ -7,11 +7,11 @@
               android:paddingLeft="8dp"
               android:paddingRight="8dp">
          
-  <ListView android:id="@id/android:list"
-            android:layout_width="fill_parent" 
-            android:layout_height="fill_parent"
-            android:layout_weight="1"
-            android:drawSelectorOnTop="false"/>
+  <ExpandableListView android:id="@id/android:list"
+                      android:layout_width="fill_parent" 
+                      android:layout_height="fill_parent"
+                      android:layout_weight="1"
+                      android:drawSelectorOnTop="false"/>
 
   <Button android:id="@+id/download"
           android:layout_width="fill_parent" 
diff --git a/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictLangCache.java b/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictLangCache.java
index 48127a87c..c8d2f81d7 100644
--- a/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictLangCache.java
+++ b/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictLangCache.java
@@ -83,7 +83,7 @@ public class DictLangCache {
 
     public static String getLangName( Context context, int code )
     {
-        String[] namesArray = getNamesArray( context );
+        String[] namesArray = getLangNames( context );
         if ( code < 0 || code >= namesArray.length ) {
             code = 0;
         }
@@ -181,7 +181,7 @@ public class DictLangCache {
     public static int getLangLangCode( Context context, String lang )
     {
         int code = 0;
-        String[] namesArray = getNamesArray( context );
+        String[] namesArray = getLangNames( context );
         for ( int ii = 0; ii < namesArray.length; ++ii ) {
             if ( namesArray[ii].equals( lang ) ) {
                 code = ii;
@@ -300,7 +300,7 @@ public class DictLangCache {
         return m_dictsAdapter;
     }
 
-    private static String[] getNamesArray( Context context )
+    public static String[] getLangNames( Context context )
     {
         if ( null == s_langNames ) {
             Resources res = context.getResources();
diff --git a/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictsActivity.java b/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictsActivity.java
index d6a7e441a..fa5c9820f 100644
--- a/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictsActivity.java
+++ b/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictsActivity.java
@@ -24,6 +24,8 @@ import android.app.Activity;
 import android.app.AlertDialog;
 import android.app.Dialog;
 import android.app.ListActivity;
+import android.app.ExpandableListActivity;
+import android.database.DataSetObserver;
 import android.os.Bundle;
 import android.widget.Button;
 import android.widget.TextView;
@@ -39,6 +41,7 @@ import android.view.MenuItem;
 import android.view.ContextMenu.ContextMenuInfo;
 import android.view.LayoutInflater;
 import android.view.MenuInflater;
+import android.widget.ExpandableListAdapter;
 import android.preference.PreferenceManager;
 import android.net.Uri;
 import junit.framework.Assert;
@@ -47,7 +50,7 @@ import org.eehouse.android.xw4.jni.XwJNI;
 import org.eehouse.android.xw4.jni.JNIUtilsImpl;
 import org.eehouse.android.xw4.jni.CommonPrefs;
 
-public class DictsActivity extends XWListActivity 
+public class DictsActivity extends ExpandableListActivity 
     implements View.OnClickListener,
                XWListItem.DeleteCallback {
 
@@ -59,34 +62,119 @@ public class DictsActivity extends XWListActivity
     private static final int PICK_STORAGE = DlgDelegate.DIALOG_LAST + 1;
     private int m_lang = 0;
     private String m_name = null;
+    private String m_download;
 
-    private class DictListAdapter extends XWListAdapter {
+    private class DictListAdapter implements ExpandableListAdapter {
         private Context m_context;
 
+        public boolean areAllItemsEnabled() { return false; }
+
+        public Object getChild(int groupPosition, int childPosition)
+        {
+            return null;
+        }
+
+        public long getChildId( int groupPosition, int childPosition )
+        {
+            return childPosition;
+        }
+
+        public View getChildView( int groupPosition, int childPosition, 
+                                  boolean isLastChild, View convertView, 
+                                  ViewGroup parent)
+        {
+            int lang = (int)getGroupId( groupPosition );
+            String[] dicts = DictLangCache.getHaveLang( m_context, lang );
+            String text;
+            if ( null != dicts && childPosition < dicts.length ) {
+                text = dicts[childPosition];
+            } else {
+                text = m_download;
+            }
+            TextView view = new TextView( m_context );
+            view.setText( text );
+            return view;
+        }
+
+        public int getChildrenCount( int groupPosition )
+        {
+            int lang = (int)getGroupId( groupPosition );
+            String[] dicts = DictLangCache.getHaveLang( m_context, lang );
+            int result = 1;     // for the download option
+            if ( null != dicts ) {
+                result += dicts.length;
+            }
+            return result;
+        }
+
+        public long getCombinedChildId( long groupId, long childId )
+        {
+            return groupId << 16 | childId;
+        }
+
+        public long getCombinedGroupId( long groupId )
+        {
+            return groupId;
+        }
+
+        public Object getGroup( int groupPosition )
+        {
+            return null;
+        }
+
+        public int getGroupCount()
+        {
+            return DictLangCache.getLangNames( m_context ).length;
+        }
+
+        public long getGroupId( int groupPosition )
+        {
+            String[] langNames = DictLangCache.getLangNames( m_context );
+            int lang = DictLangCache.getLangLangCode( m_context, langNames[groupPosition] );
+            return lang;
+        }
+
+        public View getGroupView( int groupPosition, boolean isExpanded, 
+                                  View convertView, ViewGroup parent )
+        {
+            TextView view = new TextView( m_context );
+            view.setText( DictLangCache.getLangNames(m_context)[groupPosition] );
+            return view;
+        }
+
+        public boolean hasStableIds() { return false; }
+        public boolean isChildSelectable( int groupPosition, int childPosition ) { return true; }
+        public boolean isEmpty() { return false; }
+        public void onGroupCollapsed(int groupPosition){}
+        public void onGroupExpanded(int groupPosition){}
+        public void registerDataSetObserver( DataSetObserver obs ){}
+        public void unregisterDataSetObserver( DataSetObserver obs ){}
+
+
         public DictListAdapter( Context context ) {
-            super( context, m_dicts.length );
+            //super( context, m_dicts.length );
             m_context = context;
         }
 
-        public Object getItem( int position) { return m_dicts[position]; }
-        public View getView( final int position, View convertView, 
-                             ViewGroup parent ) {
-            LayoutInflater factory = LayoutInflater.from( DictsActivity.this );
-            final XWListItem view
-                = (XWListItem)factory.inflate( R.layout.list_item, null );
-            view.setPosition( position );
+        // public Object getItem( int position) { return m_dicts[position]; }
+        // public View getView( final int position, View convertView, 
+        //                      ViewGroup parent ) {
+        //     LayoutInflater factory = LayoutInflater.from( DictsActivity.this );
+        //     final XWListItem view
+        //         = (XWListItem)factory.inflate( R.layout.list_item, null );
+        //     view.setPosition( position );
 
-            // append language name
-            view.setText( DictLangCache.
-                          annotatedDictName( DictsActivity.this, 
-                                             m_dicts[position] ) );
-            if ( !GameUtils.dictIsBuiltin( DictsActivity.this,
-                                           m_dicts[position] ) ) {
-                view.setDeleteCallback( DictsActivity.this );
-            }
+        //     // append language name
+        //     view.setText( DictLangCache.
+        //                   annotatedDictName( DictsActivity.this, 
+        //                                      m_dicts[position] ) );
+        //     if ( !GameUtils.dictIsBuiltin( DictsActivity.this,
+        //                                    m_dicts[position] ) ) {
+        //         view.setDeleteCallback( DictsActivity.this );
+        //     }
 
-            return view;
-        }
+        //     return view;
+        // }
     }
 
     @Override
@@ -119,16 +207,18 @@ public class DictsActivity extends XWListActivity
     protected void onCreate(Bundle savedInstanceState) {
         super.onCreate( savedInstanceState );
 
+        m_download = getString( R.string.download_dicts );
+
         setContentView( R.layout.dict_browse );
-        registerForContextMenu( getListView() );
+        //registerForContextMenu( getListView() );
 
         Button download = (Button)findViewById( R.id.download );
         download.setOnClickListener( this );
 
         mkListAdapter();
 
-        showNotAgainDlg( R.string.not_again_dicts, 
-                         R.string.key_notagain_dicts );
+        // showNotAgainDlg( R.string.not_again_dicts, 
+        //                  R.string.key_notagain_dicts );
 
         Intent intent = getIntent();
         if ( null != intent ) {
@@ -231,7 +321,7 @@ public class DictsActivity extends XWListActivity
             msg += String.format( getString(fmt), langName );
         }
 
-        showConfirmThen( msg, action );
+        // showConfirmThen( msg, action );
     }
 
     private void deleteDict( String dict )
@@ -261,7 +351,8 @@ public class DictsActivity extends XWListActivity
     private void mkListAdapter()
     {
         m_dicts = GameUtils.dictList( this );
-        setListAdapter( new DictListAdapter( this ) );
+        ExpandableListAdapter adapter = new DictListAdapter( this );
+        setListAdapter( adapter );
     }
 
     private static Intent mkDownloadIntent( Context context,

From a559fdaae92a6b165e85fc325a85a7ea916ca36a Mon Sep 17 00:00:00 2001
From: Andy2 <andy2@trand>
Date: Mon, 9 May 2011 06:32:30 -0700
Subject: [PATCH 02/13] use a built-in layout for top-level rows to get the
 expander drawn right.

---
 .../src/org/eehouse/android/xw4/DictsActivity.java | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictsActivity.java b/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictsActivity.java
index fa5c9820f..af9db3e8f 100644
--- a/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictsActivity.java
+++ b/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictsActivity.java
@@ -67,6 +67,11 @@ public class DictsActivity extends ExpandableListActivity
     private class DictListAdapter implements ExpandableListAdapter {
         private Context m_context;
 
+        public DictListAdapter( Context context ) {
+            //super( context, m_dicts.length );
+            m_context = context;
+        }
+
         public boolean areAllItemsEnabled() { return false; }
 
         public Object getChild(int groupPosition, int childPosition)
@@ -137,7 +142,9 @@ public class DictsActivity extends ExpandableListActivity
         public View getGroupView( int groupPosition, boolean isExpanded, 
                                   View convertView, ViewGroup parent )
         {
-            TextView view = new TextView( m_context );
+            View row = LayoutInflater.from(DictsActivity.this).
+                inflate(android.R.layout.simple_expandable_list_item_1, null );
+            TextView view = (TextView)row.findViewById( android.R.id.text1 );
             view.setText( DictLangCache.getLangNames(m_context)[groupPosition] );
             return view;
         }
@@ -151,11 +158,6 @@ public class DictsActivity extends ExpandableListActivity
         public void unregisterDataSetObserver( DataSetObserver obs ){}
 
 
-        public DictListAdapter( Context context ) {
-            //super( context, m_dicts.length );
-            m_context = context;
-        }
-
         // public Object getItem( int position) { return m_dicts[position]; }
         // public View getView( final int position, View convertView, 
         //                      ViewGroup parent ) {

From c990900913170abc2f35a0b0d7acecdf4395c31a Mon Sep 17 00:00:00 2001
From: Andy2 <andy2@trand>
Date: Mon, 9 May 2011 06:49:45 -0700
Subject: [PATCH 03/13] cache list of langs.  Performance is otherwise abysmal.
  May need to add mechanism to notify when the list is invalidated.  (Or move
 caching into DictsLangCache class.)

---
 .../src/org/eehouse/android/xw4/DictLangCache.java    |  2 +-
 .../src/org/eehouse/android/xw4/DictsActivity.java    | 11 ++++++-----
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictLangCache.java b/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictLangCache.java
index c8d2f81d7..861593a03 100644
--- a/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictLangCache.java
+++ b/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictLangCache.java
@@ -224,7 +224,7 @@ public class DictLangCache {
         }
     }
 
-    private static String[] listLangs( Context context )
+    public static String[] listLangs( Context context )
     {
         return listLangs( context, GameUtils.dictList( context ) );
     }
diff --git a/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictsActivity.java b/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictsActivity.java
index af9db3e8f..e5359544a 100644
--- a/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictsActivity.java
+++ b/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictsActivity.java
@@ -66,10 +66,12 @@ public class DictsActivity extends ExpandableListActivity
 
     private class DictListAdapter implements ExpandableListAdapter {
         private Context m_context;
+        private String[] m_langs;
 
         public DictListAdapter( Context context ) {
             //super( context, m_dicts.length );
             m_context = context;
+            m_langs = DictLangCache.listLangs( m_context );
         }
 
         public boolean areAllItemsEnabled() { return false; }
@@ -129,13 +131,13 @@ public class DictsActivity extends ExpandableListActivity
 
         public int getGroupCount()
         {
-            return DictLangCache.getLangNames( m_context ).length;
+            return m_langs.length;
         }
 
         public long getGroupId( int groupPosition )
         {
-            String[] langNames = DictLangCache.getLangNames( m_context );
-            int lang = DictLangCache.getLangLangCode( m_context, langNames[groupPosition] );
+            int lang = DictLangCache.getLangLangCode( m_context, 
+                                                      m_langs[groupPosition] );
             return lang;
         }
 
@@ -145,7 +147,7 @@ public class DictsActivity extends ExpandableListActivity
             View row = LayoutInflater.from(DictsActivity.this).
                 inflate(android.R.layout.simple_expandable_list_item_1, null );
             TextView view = (TextView)row.findViewById( android.R.id.text1 );
-            view.setText( DictLangCache.getLangNames(m_context)[groupPosition] );
+            view.setText( m_langs[groupPosition] );
             return view;
         }
 
@@ -157,7 +159,6 @@ public class DictsActivity extends ExpandableListActivity
         public void registerDataSetObserver( DataSetObserver obs ){}
         public void unregisterDataSetObserver( DataSetObserver obs ){}
 
-
         // public Object getItem( int position) { return m_dicts[position]; }
         // public View getView( final int position, View convertView, 
         //                      ViewGroup parent ) {

From 085748e20101c466f4bcb83d83ddd1235155df8b Mon Sep 17 00:00:00 2001
From: Andy2 <andy2@trand>
Date: Mon, 9 May 2011 18:59:51 -0700
Subject: [PATCH 04/13] hook up context menus, and add a delete item to replace
 the checkboxes.  Still need to disable it when dict is built-in.  And maybe
 add a different menu for languages.

---
 .../XWords4/res/menu/dicts_item_menu.xml      |   3 +
 .../eehouse/android/xw4/DictsActivity.java    | 119 +++++++++++-------
 2 files changed, 78 insertions(+), 44 deletions(-)

diff --git a/xwords4/android/XWords4/res/menu/dicts_item_menu.xml b/xwords4/android/XWords4/res/menu/dicts_item_menu.xml
index c4eca5a5e..32ee8b4a5 100644
--- a/xwords4/android/XWords4/res/menu/dicts_item_menu.xml
+++ b/xwords4/android/XWords4/res/menu/dicts_item_menu.xml
@@ -7,6 +7,9 @@
     <item android:id="@+id/dicts_item_select_robot"
           android:title="@string/dicts_item_select_robot"
           />
+    <item android:id="@+id/dicts_item_delete"
+          android:title="@string/dicts_item_delete"
+          />
     <item android:id="@+id/dicts_item_details"
           android:title="@string/dicts_item_details"
           />
diff --git a/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictsActivity.java b/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictsActivity.java
index e5359544a..7a80d166b 100644
--- a/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictsActivity.java
+++ b/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictsActivity.java
@@ -42,6 +42,8 @@ import android.view.ContextMenu.ContextMenuInfo;
 import android.view.LayoutInflater;
 import android.view.MenuInflater;
 import android.widget.ExpandableListAdapter;
+import android.widget.ExpandableListView;
+import android.widget.ExpandableListView.ExpandableListContextMenuInfo;
 import android.preference.PreferenceManager;
 import android.net.Uri;
 import junit.framework.Assert;
@@ -51,27 +53,26 @@ import org.eehouse.android.xw4.jni.JNIUtilsImpl;
 import org.eehouse.android.xw4.jni.CommonPrefs;
 
 public class DictsActivity extends ExpandableListActivity 
-    implements View.OnClickListener,
-               XWListItem.DeleteCallback {
+    implements View.OnClickListener {
 
     private static final String DICT_DOLAUNCH = "do_launch";
     private static final String DICT_LANG_EXTRA = "use_lang";
     private static final String DICT_NAME_EXTRA = "use_dict";
 
-    private String[] m_dicts;
     private static final int PICK_STORAGE = DlgDelegate.DIALOG_LAST + 1;
     private int m_lang = 0;
+    private String[] m_langs;
     private String m_name = null;
     private String m_download;
 
+    private DlgDelegate m_delegate;
+
     private class DictListAdapter implements ExpandableListAdapter {
         private Context m_context;
-        private String[] m_langs;
 
         public DictListAdapter( Context context ) {
             //super( context, m_dicts.length );
             m_context = context;
-            m_langs = DictLangCache.listLangs( m_context );
         }
 
         public boolean areAllItemsEnabled() { return false; }
@@ -183,37 +184,48 @@ public class DictsActivity extends ExpandableListActivity
     @Override
     protected Dialog onCreateDialog( int id )
     {
-        Dialog dialog = super.onCreateDialog( id );
-        switch( id ) {
-        case PICK_STORAGE:
-            DialogInterface.OnClickListener lstnrSD;
+        Dialog dialog = m_delegate.onCreateDialog( id );
+        if ( null != dialog ) {
+            switch( id ) {
+            case PICK_STORAGE:
+                DialogInterface.OnClickListener lstnrSD;
 
-            lstnrSD = new DialogInterface.OnClickListener() {
-                    public void onClick( DialogInterface dlg, int item ) {
-                        startDownload( m_lang, m_name, item != 
-                                       DialogInterface.BUTTON_POSITIVE );
-                    }
-                };
+                lstnrSD = new DialogInterface.OnClickListener() {
+                        public void onClick( DialogInterface dlg, int item ) {
+                            startDownload( m_lang, m_name, item != 
+                                           DialogInterface.BUTTON_POSITIVE );
+                        }
+                    };
 
-            dialog = new AlertDialog.Builder( this )
-                .setTitle( R.string.storeWhereTitle )
-                .setMessage( R.string.storeWhereMsg )
-                .setPositiveButton( R.string.button_internal, lstnrSD )
-                .setNegativeButton( R.string.button_sd, lstnrSD )
-                .create();
-            break;
+                dialog = new AlertDialog.Builder( this )
+                    .setTitle( R.string.storeWhereTitle )
+                    .setMessage( R.string.storeWhereMsg )
+                    .setPositiveButton( R.string.button_internal, lstnrSD )
+                    .setNegativeButton( R.string.button_sd, lstnrSD )
+                    .create();
+                break;
+            }
         }
         return dialog;
     }
 
+    @Override
+    public void onPrepareDialog( int id, Dialog dialog )
+    {
+        m_delegate.onPrepareDialog( id, dialog );
+    }
+
     @Override
     protected void onCreate(Bundle savedInstanceState) {
         super.onCreate( savedInstanceState );
 
-        m_download = getString( R.string.download_dicts );
+        m_delegate = new DlgDelegate( this );
 
+        m_download = getString( R.string.download_dicts );
+        m_langs = DictLangCache.listLangs( this );
+            
         setContentView( R.layout.dict_browse );
-        //registerForContextMenu( getListView() );
+        registerForContextMenu( getExpandableListView() );
 
         Button download = (Button)findViewById( R.id.download );
         download.setOnClickListener( this );
@@ -252,33 +264,50 @@ public class DictsActivity extends ExpandableListActivity
     {
         super.onCreateContextMenu( menu, view, menuInfo );
 
-        MenuInflater inflater = getMenuInflater();
-        inflater.inflate( R.menu.dicts_item_menu, menu );
+        ExpandableListView.ExpandableListContextMenuInfo info
+            = (ExpandableListView.ExpandableListContextMenuInfo)menuInfo;
+        long packedPosition = info.packedPosition;
+        int childPosition = ExpandableListView.
+            getPackedPositionChild( packedPosition );
+        // int groupPosition = ExpandableListView.
+        //     getPackedPositionGroup( packedPosition );
+        // Utils.logf( "onCreateContextMenu: group: %d; child: %d", 
+        //             groupPosition, childPosition );
 
-        AdapterView.AdapterContextMenuInfo info
-            = (AdapterView.AdapterContextMenuInfo)menuInfo;
+        // We don't have a menu yet for languages, just for their dict
+        // children
+        if ( childPosition >= 0 ) {
+            MenuInflater inflater = getMenuInflater();
+            inflater.inflate( R.menu.dicts_item_menu, menu );
+        }
     }
    
     @Override
     public boolean onContextItemSelected( MenuItem item ) 
     {
         boolean handled = false;
-        AdapterView.AdapterContextMenuInfo info;
+        ExpandableListContextMenuInfo info = null;
         try {
-            info = (AdapterView.AdapterContextMenuInfo) item.getMenuInfo();
+            info = (ExpandableListContextMenuInfo)item.getMenuInfo();
         } catch (ClassCastException e) {
             Utils.logf( "bad menuInfo:" + e.toString() );
             return false;
         }
         
+        TextView text = (TextView)info.targetView;
         int id = item.getItemId();
-        int position = info.position;
         switch( id ) {
         case R.id.dicts_item_select_human:
-            setDefault( R.string.key_default_dict, position );
+            setDefault( R.string.key_default_dict, text );
             break;
         case R.id.dicts_item_select_robot:
-            setDefault( R.string.key_default_robodict, position );
+            setDefault( R.string.key_default_robodict, text );
+            break;
+        case R.id.dicts_item_delete:
+            long packedPosition = info.packedPosition;
+            int groupPosition = ExpandableListView.
+                getPackedPositionGroup( packedPosition );
+            deleteDict( groupPosition, text );
             break;
         case R.id.dicts_item_details:
             Utils.notImpl( this );
@@ -288,22 +317,25 @@ public class DictsActivity extends ExpandableListActivity
         return handled;
     }
 
-    private void setDefault( int keyId, int position )
+    private void setDefault( int keyId, final TextView text )
     {
         SharedPreferences sp
             = PreferenceManager.getDefaultSharedPreferences( this );
         SharedPreferences.Editor editor = sp.edit();
         String key = getString( keyId );
-        editor.putString( key, m_dicts[position] );
+        String name = text.getText().toString();
+        editor.putString( key, name );
         editor.commit();
     }
 
     // DeleteCallback interface
-    public void deleteCalled( final int myPosition )
+    private void deleteDict( int group, TextView text )
     {
-        final String dict = m_dicts[myPosition];
-        int lang = DictLangCache.getDictLangCode( this, dict );
-        int nGames = DBUtils.countGamesUsing( this, lang );
+        final String dict = text.getText().toString();
+        Utils.logf( "deleteDict(%s)", dict );
+        String lang = m_langs[group];
+        int code = DictLangCache.getLangLangCode( this, lang );
+        int nGames = DBUtils.countGamesUsing( this, code );
         String msg = String.format( getString( R.string.confirm_delete_dictf ),
                                     dict );
         DialogInterface.OnClickListener action = 
@@ -315,16 +347,15 @@ public class DictsActivity extends ExpandableListActivity
 
         if ( nGames > 0 ) {
             int fmt;
-            if ( 1 == DictLangCache.getHaveLang( this, lang ).length ) {
+            if ( 1 == DictLangCache.getHaveLang( this, code ).length ) {
                 fmt = R.string.confirm_deleteonly_dictf;
             } else {
                 fmt = R.string.confirm_deletemore_dictf;
             }
-            String langName = DictLangCache.getLangName( this, lang );
-            msg += String.format( getString(fmt), langName );
+            msg += String.format( getString(fmt), lang );
         }
 
-        // showConfirmThen( msg, action );
+        m_delegate.showConfirmThen( msg, action );
     }
 
     private void deleteDict( String dict )
@@ -353,7 +384,7 @@ public class DictsActivity extends ExpandableListActivity
 
     private void mkListAdapter()
     {
-        m_dicts = GameUtils.dictList( this );
+        m_langs = DictLangCache.listLangs( this );
         ExpandableListAdapter adapter = new DictListAdapter( this );
         setListAdapter( adapter );
     }

From 2dbf1ac48919027d48140c87299b3ee554f6c0cb Mon Sep 17 00:00:00 2001
From: Andy2 <andy2@trand>
Date: Tue, 10 May 2011 06:27:58 -0700
Subject: [PATCH 05/13] add formatted=false to postpone fix suggested by new
 version of SDK

---
 .../android/XWords4/res/values-ca/strings.xml | 11 ++++----
 .../android/XWords4/res/values-cs/strings.xml | 10 +++----
 .../android/XWords4/res/values-sk/strings.xml | 10 +++----
 .../android/XWords4/res/values/strings.xml    | 26 ++++++++++---------
 4 files changed, 30 insertions(+), 27 deletions(-)

diff --git a/xwords4/android/XWords4/res/values-ca/strings.xml b/xwords4/android/XWords4/res/values-ca/strings.xml
index 71b092545..91b3d9b1e 100644
--- a/xwords4/android/XWords4/res/values-ca/strings.xml
+++ b/xwords4/android/XWords4/res/values-ca/strings.xml
@@ -107,7 +107,7 @@
     <string name="strs_move_across">mou (des de %s horitzontal)</string>
     <string name="strs_move_down">mou (des de %s avall)</string>
     <string name="strs_tray_at_start">Faristol a l\'inici: %s</string>
-    <string name="strss_traded_for">Ha canviat %s per %s.</string>
+    <string formatted="false" name="strss_traded_for">Ha canviat %s per %s.</string>
     <string name="str_phony_rejected">Hi ha una o més paraules no vàlides a la jugada; torn perdut!</string>
     <string name="strd_cumulative_score">Puntuació acumulada: %d</string>
     <string name="strs_new_tiles">Fitxes noves: %s</string>
@@ -276,14 +276,15 @@
     <string name="vs">vs.</string>
     <string name="dictionary">Diccionari:</string>
     <string name="summary_fmt_listening">%s està escoltant</string>
-    <string name="summary_fmt_relay">%s via repetidor, sala \"%s\"</string>
-    <string name="summary_fmt_sms">%s via SMS, s\'està marcant %s</string>
+    <string formatted="false" name="summary_fmt_relay">%s via
+    repetidor, sala \"%s\"</string>
+    <string formatted="false" name="summary_fmt_sms">%s via SMS, s\'està marcant %s</string>
     <string name="gameOver">Final de partida</string>
     <string name="movesf">%d torns jugats</string>
 
     <!-- about dialog stuff -->
-    <string name="about_versf">Crosswords per a l\'Android, Versió %s,
-    rev %s.</string>
+    <string formatted="false" name="about_versf">Crosswords per a
+    l\'Android, Versió %s, rev %s.</string>
     <string name="about_copyright">Copyright (C) 1998-2011 d\'Eric
     House. Aquest programari es troba sota la Llicència Pública General GNU.</string>
 
diff --git a/xwords4/android/XWords4/res/values-cs/strings.xml b/xwords4/android/XWords4/res/values-cs/strings.xml
index 123e00237..5e7cb41d3 100644
--- a/xwords4/android/XWords4/res/values-cs/strings.xml
+++ b/xwords4/android/XWords4/res/values-cs/strings.xml
@@ -105,12 +105,12 @@
     <string name="strs_move_across">tah (od %s napříč)</string>
     <string name="strs_move_down">tah (od %s dolů)</string>
     <string name="strs_tray_at_start">Zásobník při startu: %s</string>
-    <string name="strss_traded_for">Vyměnil %s za %s.</string>
+    <string formatted="false" name="strss_traded_for">Vyměnil %s za %s.</string>
     <string name="str_phony_rejected">Nepovolené slovo; tah ztracen!</string>
     <string name="strd_cumulative_score">Souhrnné skóre: %d</string>
     <string name="strs_new_tiles">Nové kameny: %s</string>
     <string name="str_passed">Prošel</string>
-    <string name="strsd_summaryscored">%s:%d</string>
+    <string formatted="false" name="strsd_summaryscored">%s:%d</string>
     <string name="str_lostturn">Tah byl ztracen</string>
     <string name="str_commit_confirm">Potvrdit tento tah?\n</string>
     <string name="str_local_name">%s</string>
@@ -253,13 +253,13 @@
     <string name="vs">proti</string>
     <string name="dictionary">Slovník:</string>
     <string name="summary_fmt_listening">%s listening</string>
-    <string name="summary_fmt_relay">%s přes Relay, místnost \"%s\"</string>
-    <string name="summary_fmt_sms">%s přes SMS, dialing %s</string>
+    <string formatted="false" name="summary_fmt_relay">%s přes Relay, místnost \"%s\"</string>
+    <string formatted="false" name="summary_fmt_sms">%s přes SMS, dialing %s</string>
     <string name="gameOver">Hra skončena</string>
     <string name="movesf">Bylo zahráno %d tahů</string>
 
     <!-- about dialog stuff -->
-    <string name="about_versf">Crosswords pro Android, Verze %s,
+    <string formatted="false" name="about_versf">Crosswords pro Android, Verze %s,
     revize %s.</string>
     <string name="about_copyright">Copyright (C) 1998-2011 Eric
     House. Tento software je vydán pod licencí GNU Public License.</string>
diff --git a/xwords4/android/XWords4/res/values-sk/strings.xml b/xwords4/android/XWords4/res/values-sk/strings.xml
index 78e617c5b..173d91580 100644
--- a/xwords4/android/XWords4/res/values-sk/strings.xml
+++ b/xwords4/android/XWords4/res/values-sk/strings.xml
@@ -104,12 +104,12 @@
     <string name="strs_move_across">ťah (od %s naprieč)</string>
     <string name="strs_move_down">ťah (od %s dolu)</string>
     <string name="strs_tray_at_start">Zásobník pri štarte: %s</string>
-    <string name="strss_traded_for">Vymenil %s za %s.</string>
+    <string formatted="false" name="strss_traded_for">Vymenil %s za %s.</string>
     <string name="str_phony_rejected">Nepovolené slovo; ťah stratený!</string>
     <string name="strd_cumulative_score">Celkové skóre: %d</string>
     <string name="strs_new_tiles">Nové kamene: %s</string>
     <string name="str_passed">Prešiel</string>
-    <string name="strsd_summaryscored">%s:%d</string>
+    <string formatted="false" name="strsd_summaryscored">%s:%d</string>
     <string name="str_lostturn">Ťah bol stratený</string>
     <string name="str_commit_confirm">Potvrdiť tento ťah?\n</string>
     <string name="str_local_name">%s</string>
@@ -251,13 +251,13 @@
     <string name="vs">proti</string>
     <string name="dictionary">Slovník:</string>
     <string name="summary_fmt_listening">%s listening</string>
-    <string name="summary_fmt_relay">%s cez Relay, miestnosť \"%s\"</string>
-    <string name="summary_fmt_sms">%s cez SMS, dialing %s</string>
+    <string formatted="false" name="summary_fmt_relay">%s cez Relay, miestnosť \"%s\"</string>
+    <string formatted="false" name="summary_fmt_sms">%s cez SMS, dialing %s</string>
     <string name="gameOver">Hra skončená</string>
     <string name="movesf">Bolo zahraných %d ťahov</string>
 
     <!-- about dialog stuff -->
-    <string name="about_versf">Crosswords pre Android, Verzia %s,
+    <string formatted="false" name="about_versf">Crosswords pre Android, Verzia %s,
     revize %s.</string>
     <string name="about_copyright">Copyright (C) 1998-2011 Eric
     House. Tento software je vydaný pod licenciou GNU Public License.</string>
diff --git a/xwords4/android/XWords4/res/values/strings.xml b/xwords4/android/XWords4/res/values/strings.xml
index 5456e0d79..dfdc699d4 100644
--- a/xwords4/android/XWords4/res/values/strings.xml
+++ b/xwords4/android/XWords4/res/values/strings.xml
@@ -114,18 +114,18 @@
     <string name="strs_move_across">move (from %s across)\n</string>
     <string name="strs_move_down">move (from %s down)\n</string>
     <string name="strs_tray_at_start">Rack at start: %s\n</string>
-    <string name="strss_traded_for">Exchanged %s for %s.</string>
+    <string formatted="false" name="strss_traded_for">Exchanged %s for %s.</string>
     <string name="str_phony_rejected">Illegal word in move; turn lost!</string>
     <string name="strd_cumulative_score">Cumulative score: %d\n</string>
     <string name="strs_new_tiles">New tiles: %s</string>
     <string name="str_passed">Passed</string>
-    <string name="strsd_summaryscored">%s:%d</string>
+    <string formatted="false" name="strsd_summaryscored">%s:%d</string>
     <string name="strd_traded">Traded %d</string>
     <string name="str_lostturn">Lost turn</string>
     <string name="str_commit_confirm">Commit the current move?\n</string>
     <string name="str_local_name">%s</string>
     <string name="str_nonlocal_name">%s (remote)</string>
-    <string name="str_game_namef">%s (%s)</string>
+    <string formatted="false" name="str_game_namef">%s (%s)</string>
     <string name="str_bonus_all">Bonus for using all tiles: 50\n</string>
     <string name="strd_turn_score">Score for turn: %d\n</string>
 
@@ -155,7 +155,7 @@
     <string name="player_edit_title">Edit player</string>
 
     <string name="players_label_standalone">Players</string>
-    <string name="players_label_host">Players (%d local, %d off-device)</string>
+    <string formatted="false" name="players_label_host">Players (%d local, %d off-device)</string>
     <string name="players_label_guest">Players -- local only</string>
     <string name="game_locked">Lock settings</string>
     <string name="button_add_player">Add player</string>
@@ -332,8 +332,9 @@
     <string name="tab_sms">SMS (broken)</string>
     <string name="tab_bluetooth">Bluetooth (pending)</string>
 
-    <string name="msg_relay_waiting">Device %d connected to relay in
-      room \"%s\". Waiting for %d player[s].</string>
+    <string formatted="false" name="msg_relay_waiting">Device %d
+      connected to relay in room \"%s\". Waiting for %d
+      player[s].</string>
     <string name="msg_relay_all_heref">All players are here in room
       \"%s\".</string>
     <string name="title_relay_status">Connection status.</string>
@@ -367,12 +368,12 @@
     <string name="dictionary">Dictionary:</string>
     <string name="summary_fmt_listening">%s listening</string>
     <string name="summary_fmt_relay">Connecting via Relay, room \"%s\"</string>
-    <string name="summary_fmt_sms">%s via SMS, dialing %s</string>
+    <string formatted="false" name="summary_fmt_sms">%s via SMS, dialing %s</string>
     <string name="gameOver">Game over</string>
     <string name="movesf">%d moves played</string>
 
     <!-- about dialog stuff -->
-    <string name="about_versf">Crosswords for Android, Version %s,
+    <string formatted="false" name="about_versf">Crosswords for Android, Version %s,
     rev %s.</string>
     <string name="about_copyright">Copyright (C) 1998-2011 by Eric
     House. This free/open source software is released under the GNU Public
@@ -396,7 +397,7 @@
 
     <string name="no_dictf">Unable to open game because no %s
       dictionary found.</string>
-    <string name="no_dict_substf">Unable to open game because
+    <string formatted="false" name="no_dict_substf">Unable to open game because
       dictionary %s not found. You can download a replacement or
       substitute another %s dictionary.</string>
 
@@ -428,10 +429,11 @@
 	<string name="notify_vibrate">Vibrate</string>
 	<string name="notify_other_summary">When opponent moves arrive</string>
 
-    <string name="public_names_progress">Fetching public rooms for
+    <string formatted="false" name="public_names_progress">Fetching public rooms for
     %d-player games in %s.</string>
-    <string name="no_name_found_f">No public rooms found for %d-player
-    games in %s. Try refreshing or creating your own.</string>
+    <string formatted="false" name="no_name_found_f">No public rooms
+    found for %d-player games in %s. Try refreshing or creating your
+    own.</string>
 
     <string name="chat_local_id">Me: </string>
     <string name="chat_other_id">Not me: </string>

From 75e41caf90a57fde4df2bd5cb680d35f4dba6352 Mon Sep 17 00:00:00 2001
From: Andy2 <andy2@trand>
Date: Tue, 10 May 2011 06:31:09 -0700
Subject: [PATCH 06/13] go back to using XWListItem (with its delete-me X) and
 get rid of delete context menu item.

---
 .../XWords4/res/menu/dicts_item_menu.xml      |  3 -
 .../eehouse/android/xw4/DictsActivity.java    | 82 ++++++++++---------
 .../org/eehouse/android/xw4/GameConfig.java   |  2 +-
 .../org/eehouse/android/xw4/XWListItem.java   | 10 ++-
 4 files changed, 52 insertions(+), 45 deletions(-)

diff --git a/xwords4/android/XWords4/res/menu/dicts_item_menu.xml b/xwords4/android/XWords4/res/menu/dicts_item_menu.xml
index 32ee8b4a5..c4eca5a5e 100644
--- a/xwords4/android/XWords4/res/menu/dicts_item_menu.xml
+++ b/xwords4/android/XWords4/res/menu/dicts_item_menu.xml
@@ -7,9 +7,6 @@
     <item android:id="@+id/dicts_item_select_robot"
           android:title="@string/dicts_item_select_robot"
           />
-    <item android:id="@+id/dicts_item_delete"
-          android:title="@string/dicts_item_delete"
-          />
     <item android:id="@+id/dicts_item_details"
           android:title="@string/dicts_item_details"
           />
diff --git a/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictsActivity.java b/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictsActivity.java
index 7a80d166b..0f7a66484 100644
--- a/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictsActivity.java
+++ b/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictsActivity.java
@@ -53,7 +53,7 @@ import org.eehouse.android.xw4.jni.JNIUtilsImpl;
 import org.eehouse.android.xw4.jni.CommonPrefs;
 
 public class DictsActivity extends ExpandableListActivity 
-    implements View.OnClickListener {
+    implements View.OnClickListener, XWListItem.DeleteCallback {
 
     private static final String DICT_DOLAUNCH = "do_launch";
     private static final String DICT_LANG_EXTRA = "use_lang";
@@ -66,6 +66,7 @@ public class DictsActivity extends ExpandableListActivity
     private String m_download;
 
     private DlgDelegate m_delegate;
+    LayoutInflater m_factory;
 
     private class DictListAdapter implements ExpandableListAdapter {
         private Context m_context;
@@ -94,13 +95,21 @@ public class DictsActivity extends ExpandableListActivity
             int lang = (int)getGroupId( groupPosition );
             String[] dicts = DictLangCache.getHaveLang( m_context, lang );
             String text;
+            boolean canDelete = false;
             if ( null != dicts && childPosition < dicts.length ) {
                 text = dicts[childPosition];
+                canDelete = !GameUtils.dictIsBuiltin( DictsActivity.this,
+                                                      text );
             } else {
                 text = m_download;
             }
-            TextView view = new TextView( m_context );
+            XWListItem view =
+                (XWListItem)m_factory.inflate( R.layout.list_item, null );
             view.setText( text );
+            if ( canDelete ) {
+                view.setDeleteCallback( DictsActivity.this );
+            }
+
             return view;
         }
 
@@ -108,7 +117,7 @@ public class DictsActivity extends ExpandableListActivity
         {
             int lang = (int)getGroupId( groupPosition );
             String[] dicts = DictLangCache.getHaveLang( m_context, lang );
-            int result = 1;     // for the download option
+            int result = 0; // 1;     // 1 for the download option
             if ( null != dicts ) {
                 result += dicts.length;
             }
@@ -184,27 +193,28 @@ public class DictsActivity extends ExpandableListActivity
     @Override
     protected Dialog onCreateDialog( int id )
     {
-        Dialog dialog = m_delegate.onCreateDialog( id );
-        if ( null != dialog ) {
-            switch( id ) {
-            case PICK_STORAGE:
-                DialogInterface.OnClickListener lstnrSD;
+        Dialog dialog;
+        switch( id ) {
+        case PICK_STORAGE:
+            DialogInterface.OnClickListener lstnrSD;
 
-                lstnrSD = new DialogInterface.OnClickListener() {
-                        public void onClick( DialogInterface dlg, int item ) {
-                            startDownload( m_lang, m_name, item != 
-                                           DialogInterface.BUTTON_POSITIVE );
-                        }
-                    };
+            lstnrSD = new DialogInterface.OnClickListener() {
+                    public void onClick( DialogInterface dlg, int item ) {
+                        startDownload( m_lang, m_name, item != 
+                                       DialogInterface.BUTTON_POSITIVE );
+                    }
+                };
 
-                dialog = new AlertDialog.Builder( this )
-                    .setTitle( R.string.storeWhereTitle )
-                    .setMessage( R.string.storeWhereMsg )
-                    .setPositiveButton( R.string.button_internal, lstnrSD )
-                    .setNegativeButton( R.string.button_sd, lstnrSD )
-                    .create();
-                break;
-            }
+            dialog = new AlertDialog.Builder( this )
+                .setTitle( R.string.storeWhereTitle )
+                .setMessage( R.string.storeWhereMsg )
+                .setPositiveButton( R.string.button_internal, lstnrSD )
+                .setNegativeButton( R.string.button_sd, lstnrSD )
+                .create();
+            break;
+        default:
+            dialog = m_delegate.onCreateDialog( id );
+            break;
         }
         return dialog;
     }
@@ -216,10 +226,12 @@ public class DictsActivity extends ExpandableListActivity
     }
 
     @Override
-    protected void onCreate(Bundle savedInstanceState) {
+    protected void onCreate(Bundle savedInstanceState) 
+    {
         super.onCreate( savedInstanceState );
 
         m_delegate = new DlgDelegate( this );
+        m_factory = LayoutInflater.from( this );
 
         m_download = getString( R.string.download_dicts );
         m_langs = DictLangCache.listLangs( this );
@@ -294,20 +306,14 @@ public class DictsActivity extends ExpandableListActivity
             return false;
         }
         
-        TextView text = (TextView)info.targetView;
+        XWListItem row = (XWListItem)info.targetView;
         int id = item.getItemId();
         switch( id ) {
         case R.id.dicts_item_select_human:
-            setDefault( R.string.key_default_dict, text );
+            setDefault( R.string.key_default_dict, row );
             break;
         case R.id.dicts_item_select_robot:
-            setDefault( R.string.key_default_robodict, text );
-            break;
-        case R.id.dicts_item_delete:
-            long packedPosition = info.packedPosition;
-            int groupPosition = ExpandableListView.
-                getPackedPositionGroup( packedPosition );
-            deleteDict( groupPosition, text );
+            setDefault( R.string.key_default_robodict, row );
             break;
         case R.id.dicts_item_details:
             Utils.notImpl( this );
@@ -317,24 +323,22 @@ public class DictsActivity extends ExpandableListActivity
         return handled;
     }
 
-    private void setDefault( int keyId, final TextView text )
+    private void setDefault( int keyId, final XWListItem text )
     {
         SharedPreferences sp
             = PreferenceManager.getDefaultSharedPreferences( this );
         SharedPreferences.Editor editor = sp.edit();
         String key = getString( keyId );
-        String name = text.getText().toString();
+        String name = text.getText();
         editor.putString( key, name );
         editor.commit();
     }
 
     // DeleteCallback interface
-    private void deleteDict( int group, TextView text )
+    public void deleteCalled( int myPosition, final String dict )
     {
-        final String dict = text.getText().toString();
-        Utils.logf( "deleteDict(%s)", dict );
-        String lang = m_langs[group];
-        int code = DictLangCache.getLangLangCode( this, lang );
+        int code = DictLangCache.getDictLangCode( this, dict );
+        String lang = DictLangCache.getLangName( this, code );
         int nGames = DBUtils.countGamesUsing( this, code );
         String msg = String.format( getString( R.string.confirm_delete_dictf ),
                                     dict );
diff --git a/xwords4/android/XWords4/src/org/eehouse/android/xw4/GameConfig.java b/xwords4/android/XWords4/src/org/eehouse/android/xw4/GameConfig.java
index 3b10e0049..ddc634b08 100644
--- a/xwords4/android/XWords4/src/org/eehouse/android/xw4/GameConfig.java
+++ b/xwords4/android/XWords4/src/org/eehouse/android/xw4/GameConfig.java
@@ -501,7 +501,7 @@ public class GameConfig extends XWActivity
     }
 
     // DeleteCallback interface
-    public void deleteCalled( int myPosition )
+    public void deleteCalled( int myPosition, final String name )
     {
         if ( m_gi.delete( myPosition ) ) {
             loadPlayers();
diff --git a/xwords4/android/XWords4/src/org/eehouse/android/xw4/XWListItem.java b/xwords4/android/XWords4/src/org/eehouse/android/xw4/XWListItem.java
index 791e39a30..57240e493 100644
--- a/xwords4/android/XWords4/src/org/eehouse/android/xw4/XWListItem.java
+++ b/xwords4/android/XWords4/src/org/eehouse/android/xw4/XWListItem.java
@@ -34,7 +34,7 @@ public class XWListItem extends LinearLayout {
     DeleteCallback m_cb;
 
     public interface DeleteCallback {
-        void deleteCalled( int myPosition );
+        void deleteCalled( int myPosition, String name );
     }
 
     public XWListItem( Context cx, AttributeSet as ) {
@@ -51,6 +51,12 @@ public class XWListItem extends LinearLayout {
         view.setText( text );
     }
 
+    public String getText()
+    {
+        TextView view = (TextView)getChildAt( 0 );
+        return view.getText().toString();
+    }
+
     public void setDeleteCallback( DeleteCallback cb ) 
     {
         m_cb = cb;
@@ -58,7 +64,7 @@ public class XWListItem extends LinearLayout {
         button.setOnClickListener( new View.OnClickListener() {
                 @Override
                     public void onClick( View view ) {
-                    m_cb.deleteCalled( m_position );
+                    m_cb.deleteCalled( m_position, getText() );
                 }
             } );
         button.setVisibility( View.VISIBLE );

From 472ffd02bfce0caa7c5873ec9633b9d03e16010a Mon Sep 17 00:00:00 2001
From: Andy2 <andy2@trand>
Date: Tue, 10 May 2011 18:24:57 -0700
Subject: [PATCH 07/13] fix getting wrong networked window title even when
 configuring a non-networked game.  And remove no-op method call.

---
 .../src/org/eehouse/android/xw4/GameConfig.java   | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/xwords4/android/XWords4/src/org/eehouse/android/xw4/GameConfig.java b/xwords4/android/XWords4/src/org/eehouse/android/xw4/GameConfig.java
index ddc634b08..4975b35a7 100644
--- a/xwords4/android/XWords4/src/org/eehouse/android/xw4/GameConfig.java
+++ b/xwords4/android/XWords4/src/org/eehouse/android/xw4/GameConfig.java
@@ -395,10 +395,7 @@ public class GameConfig extends XWActivity
         m_phoniesSpinner = (Spinner)findViewById( R.id.phonies_spinner );
         m_smartnessSpinner = (Spinner)findViewById( R.id.smart_robot );
 
-        String fmt = getString( m_notNetworkedGame ?
-                                R.string.title_game_configf
-                                : R.string.title_gamenet_configf );
-        setTitle( String.format( fmt, GameUtils.gameName( this, m_path ) ) );
+        setTitle();
     } // onCreate
 
     @Override
@@ -414,7 +411,6 @@ public class GameConfig extends XWActivity
         GameUtils.loadMakeGame( this, gamePtr, m_giOrig, m_gameLock );
         m_gameStarted = XwJNI.model_getNMoves( gamePtr ) > 0
             || XwJNI.comms_isConnected( gamePtr );
-        m_giOrig.setInProgress( m_gameStarted );
 
         if ( m_gameStarted ) {
             if ( null == m_gameLockedCheck ) {
@@ -442,6 +438,7 @@ public class GameConfig extends XWActivity
         m_car = new CommsAddrRec( m_carOrig );
 
         m_notNetworkedGame = DeviceRole.SERVER_STANDALONE == m_gi.serverRole;
+        setTitle();
 
         if ( !m_notNetworkedGame ) {
             m_joinPublicCheck = 
@@ -977,4 +974,12 @@ public class GameConfig extends XWActivity
                               m_gi.nPlayers, m_roomChoose ).execute();
     }
 
+    private void setTitle()
+    {
+        String fmt = getString( m_notNetworkedGame ?
+                                R.string.title_game_configf
+                                : R.string.title_gamenet_configf );
+        setTitle( String.format( fmt, GameUtils.gameName( this, m_path ) ) );
+    }
+
 }

From 8a8e1c9db06919d6215521607a12814912b2149f Mon Sep 17 00:00:00 2001
From: Andy2 <andy2@trand>
Date: Tue, 10 May 2011 18:25:27 -0700
Subject: [PATCH 08/13] remove no-op method and call of same

---
 .../XWords4/src/org/eehouse/android/xw4/GameUtils.java    | 3 ---
 .../src/org/eehouse/android/xw4/jni/CurGameInfo.java      | 8 --------
 2 files changed, 11 deletions(-)

diff --git a/xwords4/android/XWords4/src/org/eehouse/android/xw4/GameUtils.java b/xwords4/android/XWords4/src/org/eehouse/android/xw4/GameUtils.java
index 7dd4a7d0e..0ce71bfe2 100644
--- a/xwords4/android/XWords4/src/org/eehouse/android/xw4/GameUtils.java
+++ b/xwords4/android/XWords4/src/org/eehouse/android/xw4/GameUtils.java
@@ -189,8 +189,6 @@ public class GameUtils {
         }
         XwJNI.game_dispose( gamePtr );
 
-        gi.setInProgress( false );
-
         gamePtr = XwJNI.initJNI();
         XwJNI.game_makeNewGame( gamePtr, gi, JNIUtilsImpl.get(), 
                                 CommonPrefs.get( context ), dictBytes, 
@@ -749,7 +747,6 @@ public class GameUtils {
         }
 
         if ( forceNew || !madeGame ) {
-            gi.setInProgress( false );
             XwJNI.game_makeNewGame( gamePtr, gi, JNIUtilsImpl.get(), 
                                     cp, dictBytes, dictNames, langName );
         }
diff --git a/xwords4/android/XWords4/src/org/eehouse/android/xw4/jni/CurGameInfo.java b/xwords4/android/XWords4/src/org/eehouse/android/xw4/jni/CurGameInfo.java
index 014b70a85..2a7c8ebde 100644
--- a/xwords4/android/XWords4/src/org/eehouse/android/xw4/jni/CurGameInfo.java
+++ b/xwords4/android/XWords4/src/org/eehouse/android/xw4/jni/CurGameInfo.java
@@ -56,7 +56,6 @@ public class CurGameInfo {
 
     // private int[] m_visiblePlayers;
     // private int m_nVisiblePlayers;
-    private boolean m_inProgress;
     private int m_smartness;
     private Context m_context;
 
@@ -67,7 +66,6 @@ public class CurGameInfo {
 
     public CurGameInfo( Context context, boolean isNetworked )
     {
-        m_inProgress = false;
         m_context = context;
         nPlayers = 2;
         gameSeconds = 60 * nPlayers *
@@ -103,7 +101,6 @@ public class CurGameInfo {
     public CurGameInfo( Context context, CurGameInfo src )
     {
         m_context = context;
-        m_inProgress = src.m_inProgress;
         gameID = src.gameID;
         nPlayers = src.nPlayers;
         gameSeconds = src.gameSeconds;
@@ -134,11 +131,6 @@ public class CurGameInfo {
         }
     }
 
-    public void setInProgress( boolean inProgress )
-    {
-        m_inProgress = inProgress;
-    }
-
     public void setLang( int lang )
     {
         if ( dictLang != lang ) {

From dd27a0ebcd8d6c1ecffbc8eeeb3fe9709b31b338 Mon Sep 17 00:00:00 2001
From: Eric House <eehouse@eehouse.org>
Date: Tue, 10 May 2011 18:26:54 -0700
Subject: [PATCH 09/13] first cut at script to do stuff with xml string
 resources, e.g. find strings that aren't used

---
 xwords4/android/scripts/strings_check.sh | 57 ++++++++++++++++++++++++
 1 file changed, 57 insertions(+)
 create mode 100755 xwords4/android/scripts/strings_check.sh

diff --git a/xwords4/android/scripts/strings_check.sh b/xwords4/android/scripts/strings_check.sh
new file mode 100755
index 000000000..385724f24
--- /dev/null
+++ b/xwords4/android/scripts/strings_check.sh
@@ -0,0 +1,57 @@
+#!/bin/bash
+
+set -u -e
+
+declare -A ENG_IDS
+LOCS=""
+SEARCH_SOURCE=""
+
+ENG=~/dev/git/ANDROID_BRANCH/xwords4/android/XWords4/res/values/strings.xml
+
+usage() {
+    echo "usage: $0 [--loc <path_to_strings.xml>]*" >&2
+    exit 1
+}
+
+list_ids() {
+    XML_FILE=$1
+    xmlstarlet sel -T -t -m "/resources/string" -v @name -o " " $XML_FILE
+}
+
+while [ $# -gt 0 ]; do
+    case $1 in
+        --loc)
+            [ $# -gt 1 ] || usage
+            [ -e $2 ] || usage
+            LOCS="$LOCS $2"
+            shift
+            ;;
+        *)
+            usage
+            ;;
+    esac
+    shift
+done
+
+# echo "checking $ENG for ids not in any .java file"
+for ID in $(list_ids $ENG); do
+    ENG_IDS[$ID]=1
+done
+
+if [ -n "$SEARCH_SOURCE" ]; then
+    if grep -q R.string.$ID $(find . -name '*.java'); then
+        :
+    elif grep -q "@string/$ID" $(find . -name '*.xml'); then
+        :
+    else
+        echo "$ID appears to be unused"
+    fi
+fi
+
+
+for LOC in $LOCS; do
+    IDS="${!ENG_IDS[*]}"
+    for ID in $IDS; do
+        grep -q $ID $LOC || echo "$ID not found in $LOC"
+    done
+done
\ No newline at end of file

From af96e184d733f5a45f9da03da7bd90a865d547e1 Mon Sep 17 00:00:00 2001
From: Andy2 <andy2@trand>
Date: Tue, 10 May 2011 18:34:39 -0700
Subject: [PATCH 10/13] don't refresh public room names when game is locked.

---
 .../XWords4/src/org/eehouse/android/xw4/GameConfig.java     | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/xwords4/android/XWords4/src/org/eehouse/android/xw4/GameConfig.java b/xwords4/android/XWords4/src/org/eehouse/android/xw4/GameConfig.java
index 4975b35a7..252db02a6 100644
--- a/xwords4/android/XWords4/src/org/eehouse/android/xw4/GameConfig.java
+++ b/xwords4/android/XWords4/src/org/eehouse/android/xw4/GameConfig.java
@@ -970,8 +970,10 @@ public class GameConfig extends XWActivity
 
     private void refreshNames()
     {
-        new RefreshNamesTask( this, this, m_gi.dictLang, 
-                              m_gi.nPlayers, m_roomChoose ).execute();
+        if ( !m_isLocked ) {
+            new RefreshNamesTask( this, this, m_gi.dictLang, 
+                                  m_gi.nPlayers, m_roomChoose ).execute();
+        }
     }
 
     private void setTitle()

From 782a9f1f7035df90e064c5d20027d33a9d72e0e7 Mon Sep 17 00:00:00 2001
From: Andy2 <andy2@trand>
Date: Tue, 10 May 2011 18:36:04 -0700
Subject: [PATCH 11/13] get rid of strings that don't seem to be used anymore. 
 Still need to pull from localized files.

---
 .../android/XWords4/res/values/strings.xml    | 51 +------------------
 1 file changed, 1 insertion(+), 50 deletions(-)

diff --git a/xwords4/android/XWords4/res/values/strings.xml b/xwords4/android/XWords4/res/values/strings.xml
index dfdc699d4..c2270b12b 100644
--- a/xwords4/android/XWords4/res/values/strings.xml
+++ b/xwords4/android/XWords4/res/values/strings.xml
@@ -15,11 +15,9 @@
 -->
 
 <resources>
-    <string name="menu_delete">Delete</string>
     <string name="button_new_game">Add single-device game</string>
     <string name="button_new_game_net">Add multi-device game</string>
 
-    <string name="list_item_play">Play game</string>
     <string name="list_item_config">Game settings...</string>
     <string name="list_item_hide">Hide</string>
     <string name="list_item_delete">Delete</string>
@@ -33,12 +31,9 @@
 	<string name="list_item_move_to_bottom">Move to bottom</string>
 
     <string name="resolve_edit">Edit note</string>
-    <string name="resolve_title">Edit title</string>  
 
     <string name="play">Play game</string>
 
-    <string name="title_create">Create game</string>
-    <string name="title_edit">Edit game</string>
 	<string name="title_games_list">Crosswords</string>   
 	<string name="title_dicts_list">Dictionaries (wordcount)</string>   
     <string name="title_langs_list">Languages (based on installed
@@ -60,13 +55,9 @@
 	<string name="button_retry">Retry</string>  
 
     <string name="player_label">Name:</string>
-    <string name="game_config_open">Open</string>
-    <string name="game_config_revert">Revert changes</string>
 
-	<string name="error_title">Error</string>
 	<string name="info_title">FYI...</string>
 	<string name="newbie_title">New user info</string>
-	<string name="error_message">Error loading game</string>
 	<string name="query_title">A question...</string>
 	<string name="query_trade">Are you sure you want to exchange the selected tiles?</string>
 
@@ -79,14 +70,10 @@
 
     <!-- system menu for main board view -->
 	<string name="board_menu_done">Turn done</string>
-	<string name="board_menu_juggle">Shuffle</string>
-	<string name="board_menu_flip">Flip</string>
 	<string name="board_menu_trade">Exchange tiles</string>
     <string name="board_menu_trade_commit">Exchange done</string>
     <string name="board_menu_trade_cancel">Cancel exchange</string>
 	<string name="board_menu_tray">Hide rack</string>
-	<string name="board_submenu_undo">Undo</string>
-	<string name="board_menu_undo_current">Undo current</string>
 	<string name="board_menu_undo_last">Undo last</string>
 	<string name="board_menu_values">Show values</string>
 	<string name="board_submenu_game">Game</string>
@@ -95,8 +82,6 @@
 	<string name="board_menu_game_history">Game history</string>
 	<string name="board_menu_game_final">Final scores</string>
 	<string name="board_menu_game_resend">Resend messages</string>
-	<string name="board_submenu_file">File</string>
-	<string name="board_menu_file_new">New game</string>
 	<string name="board_menu_file_about">About Crosswords</string>
 
 	<string name="gamel_menu_delete_all">Delete all</string>
@@ -114,7 +99,7 @@
     <string name="strs_move_across">move (from %s across)\n</string>
     <string name="strs_move_down">move (from %s down)\n</string>
     <string name="strs_tray_at_start">Rack at start: %s\n</string>
-    <string formatted="false" name="strss_traded_for">Exchanged %s for %s.</string>
+    <string name="strss_traded_for">Exchanged %1$s for %2$s.</string>
     <string name="str_phony_rejected">Illegal word in move; turn lost!</string>
     <string name="strd_cumulative_score">Cumulative score: %d\n</string>
     <string name="strs_new_tiles">New tiles: %s</string>
@@ -156,22 +141,15 @@
 
     <string name="players_label_standalone">Players</string>
     <string formatted="false" name="players_label_host">Players (%d local, %d off-device)</string>
-    <string name="players_label_guest">Players -- local only</string>
     <string name="game_locked">Lock settings</string>
     <string name="button_add_player">Add player</string>
     <string name="button_juggle_players">Shuffle players</string>
 
-    <string name="list_item_up">Up one</string>
-    <string name="list_item_down">Down one</string>
     <string name="dicts_item_select_human">Make default (human)</string>
     <string name="dicts_item_select_robot">Make default (robot)</string>
-    <string name="dicts_item_delete">Delete dictionary</string>
     <string name="dicts_item_details">Details</string>
 
-    <string name="dict_label">Dictionary</string>
     <string name="dict_lang_labelf">Dictionary (in %s)</string>
-    <string name="role_label">Device role</string>
-    <string name="connection_label">Connection</string>
     <string name="connect_label">Connection (via internet)</string>
     <string name="room_public">Make new room public</string>
     <string name="join_room">Join public room</string>
@@ -262,13 +240,6 @@
     <string name="confirm_revert_all">Are you sure you want to restore
     all preferences to their default values?</string>
 
-    <string name="room_label">Room</string>
-    <string name="phone_label">Host phone number</string>
-    <string name="bluetooth_label">Bluetooth support coming soon....</string>
-    <string name="role_edit_title">Connection</string>
-    <string name="connect_prompt">How will Host and Guest devices
-    communicate?</string>
-
     <string name="prefs_defaults">New game defaults</string>
     <string name="prefs_defaults_summary">Default settings for new
     games</string>
@@ -289,9 +260,6 @@
     <string name="phonies_spinner_prompt">How to handle \"phonies\"
     (words not in dictionary)</string>
     <string name="board_size">Board size</string>
-    <string name="default_timerenabled">Use game timer</string>
-
-    <string name="manage_dicts">Choose</string>
 
     <string name="prefs_colors">Individual colors</string>
     <string name="prefs_colors_summary">Edit colors used on the board</string>
@@ -321,12 +289,7 @@
     <string name="logging_on">Enable logging</string>
     <string name="relay_port">Relay game port</string>
     <string name="proxy_port">Relay device port</string>
-    <string name="sms_port">SMS port</string>
 
-    <string name="sms_phone_label">sms_phone_label</string>
-    <string name="sms_port_label">sms_port_label</string>
-    <string name="bt_label">bt_label</string>
-    <string name="list_item_view">list_item_view</string>
     <string name="key_player">key_player</string>
     <string name="tab_relay">Internet/Relay</string>
     <string name="tab_sms">SMS (broken)</string>
@@ -337,7 +300,6 @@
       player[s].</string>
     <string name="msg_relay_all_heref">All players are here in room
       \"%s\".</string>
-    <string name="title_relay_status">Connection status.</string>
 
     <string name="relay_alert">Connection problem</string>
     <string name="msg_too_many">You are providing more players than the host expects.</string>
@@ -360,15 +322,9 @@
     <string name="force_expl">In a multi-device game there must be at
     least one player from and another not from this device.  Please
     check off-device players.</string>
-    <string name="added_player">Player added to meet two-player
-    minimum for multi-device games.</string>
     <string name="forced_consistent">Modified first player.</string>
 
-    <string name="vs">vs.</string>
-    <string name="dictionary">Dictionary:</string>
-    <string name="summary_fmt_listening">%s listening</string>
     <string name="summary_fmt_relay">Connecting via Relay, room \"%s\"</string>
-    <string formatted="false" name="summary_fmt_sms">%s via SMS, dialing %s</string>
     <string name="gameOver">Game over</string>
     <string name="movesf">%d moves played</string>
 
@@ -469,11 +425,6 @@
       messaging between devices in this game.  Messages will be kept
       until you delete the game that contains them.</string>
 
-    <string name="not_again_relay">Multi-device games work through an
-      internet relay that connects devices in \"rooms\".  To play
-      against a friend, make sure you both specify the same room name.
-      Or try joining or creating a public room.</string>
-
     <string name="not_again_newgame">The new game you have created has
       two players. Player 1 is a robot; Player 2 is you. Tap the game
       to play; long-tap (hold your finger on the game) to change its

From ec1e8674ecc8967742c8b76c8a0f50cac8f4172c Mon Sep 17 00:00:00 2001
From: Andy2 <andy2@trand>
Date: Tue, 10 May 2011 18:36:48 -0700
Subject: [PATCH 12/13] replace placeholder language names with empty strings
 so, maybe, can elect not to display

---
 xwords4/android/XWords4/res/values/common_rsrc.xml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/xwords4/android/XWords4/res/values/common_rsrc.xml b/xwords4/android/XWords4/res/values/common_rsrc.xml
index fb47530a2..ab39f1f73 100644
--- a/xwords4/android/XWords4/res/values/common_rsrc.xml
+++ b/xwords4/android/XWords4/res/values/common_rsrc.xml
@@ -114,7 +114,7 @@
   </string-array>
 
   <string-array name="language_names">
-    <item>Unknown</item>
+    <item></item> <!-- Unknown -->
     <item>English</item>
     <item>French</item>
     <item>German</item>
@@ -128,9 +128,9 @@
     <item>Dutch</item>
     <item>Catalan</item>
     <item>Portuguese</item>
-    <item>E</item>
+    <item></item> <!-- E -->
     <item>Russian</item>
-    <item>10</item>
+    <item></item> <!-- 10 -->
     <item>Czech</item>
     <item>Greek</item>
     <item>Slovak</item>

From b4b54c5fb9a9952ca26224e0bbec334eea0a1bb9 Mon Sep 17 00:00:00 2001
From: Andy2 <andy2@trand>
Date: Tue, 10 May 2011 18:52:47 -0700
Subject: [PATCH 13/13] quick hack to open up all groups.  Need eventually to
 remember how user sets 'em.

---
 .../src/org/eehouse/android/xw4/DictsActivity.java | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictsActivity.java b/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictsActivity.java
index 0f7a66484..937f5d8ea 100644
--- a/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictsActivity.java
+++ b/xwords4/android/XWords4/src/org/eehouse/android/xw4/DictsActivity.java
@@ -64,6 +64,7 @@ public class DictsActivity extends ExpandableListActivity
     private String[] m_langs;
     private String m_name = null;
     private String m_download;
+    private ExpandableListView m_expView;
 
     private DlgDelegate m_delegate;
     LayoutInflater m_factory;
@@ -234,10 +235,10 @@ public class DictsActivity extends ExpandableListActivity
         m_factory = LayoutInflater.from( this );
 
         m_download = getString( R.string.download_dicts );
-        m_langs = DictLangCache.listLangs( this );
             
         setContentView( R.layout.dict_browse );
-        registerForContextMenu( getExpandableListView() );
+        m_expView = getExpandableListView();
+        registerForContextMenu( m_expView );
 
         Button download = (Button)findViewById( R.id.download );
         download.setOnClickListener( this );
@@ -263,6 +264,7 @@ public class DictsActivity extends ExpandableListActivity
     {
         super.onResume();
         mkListAdapter();
+        expandGroups();
     }
 
     public void onClick( View v ) 
@@ -389,10 +391,18 @@ public class DictsActivity extends ExpandableListActivity
     private void mkListAdapter()
     {
         m_langs = DictLangCache.listLangs( this );
+        //m_langs = DictLangCache.getLangNames( this );
         ExpandableListAdapter adapter = new DictListAdapter( this );
         setListAdapter( adapter );
     }
 
+    private void expandGroups()
+    {
+        for ( int ii = 0; ii < m_langs.length; ++ii ) {
+            m_expView.expandGroup( ii );
+        }
+    }
+
     private static Intent mkDownloadIntent( Context context,
                                             int lang, String dict )
     {