From 863bdac00874b63c6871b105fdd0b6f1242b834a Mon Sep 17 00:00:00 2001 From: Andy2 Date: Mon, 18 Jul 2011 18:30:36 -0700 Subject: [PATCH] fix format specifier to not crash (use %h); remove redundant logging. --- .../src/org/eehouse/android/xw4/BoardActivity.java | 1 - .../src/org/eehouse/android/xw4/XWActivity.java | 14 +++++++------- .../org/eehouse/android/xw4/XWListActivity.java | 14 +++++++------- 3 files changed, 14 insertions(+), 15 deletions(-) diff --git a/xwords4/android/XWords4/src/org/eehouse/android/xw4/BoardActivity.java b/xwords4/android/XWords4/src/org/eehouse/android/xw4/BoardActivity.java index 82a39d8d3..547c15579 100644 --- a/xwords4/android/XWords4/src/org/eehouse/android/xw4/BoardActivity.java +++ b/xwords4/android/XWords4/src/org/eehouse/android/xw4/BoardActivity.java @@ -314,7 +314,6 @@ public class BoardActivity extends XWActivity @Override protected void onCreate( Bundle savedInstanceState ) { - Utils.logf( "BoardActivity::onCreate()" ); super.onCreate( savedInstanceState ); if ( CommonPrefs.getHideTitleBar( this ) ) { diff --git a/xwords4/android/XWords4/src/org/eehouse/android/xw4/XWActivity.java b/xwords4/android/XWords4/src/org/eehouse/android/xw4/XWActivity.java index ff3188459..d093924b6 100644 --- a/xwords4/android/XWords4/src/org/eehouse/android/xw4/XWActivity.java +++ b/xwords4/android/XWords4/src/org/eehouse/android/xw4/XWActivity.java @@ -38,7 +38,7 @@ public class XWActivity extends Activity { protected void onCreate( Bundle savedInstanceState ) { - Utils.logf( "%s.onCreate(this=%x)", getClass().getName(), this ); + Utils.logf( "%s.onCreate(this=%H)", getClass().getName(), this ); super.onCreate( savedInstanceState ); m_delegate = new DlgDelegate( this ); } @@ -46,7 +46,7 @@ public class XWActivity extends Activity { @Override protected void onStart() { - Utils.logf( "%s.onStart(this=%x)", getClass().getName(), this ); + Utils.logf( "%s.onStart(this=%H)", getClass().getName(), this ); super.onStart(); DispatchNotify.SetRunning( this ); } @@ -54,21 +54,21 @@ public class XWActivity extends Activity { @Override protected void onResume() { - Utils.logf( "%s.onResume(this=%x)", getClass().getName(), this ); + Utils.logf( "%s.onResume(this=%H)", getClass().getName(), this ); super.onResume(); } @Override protected void onPause() { - Utils.logf( "%s.onPause(this=%x)", getClass().getName(), this ); + Utils.logf( "%s.onPause(this=%H)", getClass().getName(), this ); super.onPause(); } @Override protected void onStop() { - Utils.logf( "%s.onStop(this=%x)", getClass().getName(), this ); + Utils.logf( "%s.onStop(this=%H)", getClass().getName(), this ); DispatchNotify.ClearRunning( this ); super.onStop(); } @@ -76,8 +76,8 @@ public class XWActivity extends Activity { @Override protected void onDestroy() { - Utils.logf( "%s.onDestroy(this=%x); isFinishing=%s", - getClass().getName(), this, isFinishing()?"true":"false" ); + Utils.logf( "%s.onDestroy(this=%H); isFinishing=%b", + getClass().getName(), this, isFinishing() ); super.onDestroy(); } diff --git a/xwords4/android/XWords4/src/org/eehouse/android/xw4/XWListActivity.java b/xwords4/android/XWords4/src/org/eehouse/android/xw4/XWListActivity.java index aba98a59e..77fe99799 100644 --- a/xwords4/android/XWords4/src/org/eehouse/android/xw4/XWListActivity.java +++ b/xwords4/android/XWords4/src/org/eehouse/android/xw4/XWListActivity.java @@ -33,7 +33,7 @@ public class XWListActivity extends ListActivity { @Override protected void onCreate( Bundle savedInstanceState ) { - Utils.logf( "%s.onCreate(this=%x)", getClass().getName(), this ); + Utils.logf( "%s.onCreate(this=%H)", getClass().getName(), this ); super.onCreate( savedInstanceState ); m_delegate = new DlgDelegate( this ); } @@ -41,7 +41,7 @@ public class XWListActivity extends ListActivity { @Override protected void onStart() { - Utils.logf( "%s.onStart(this=%x)", getClass().getName(), this ); + Utils.logf( "%s.onStart(this=%H)", getClass().getName(), this ); super.onStart(); DispatchNotify.SetRunning( this ); } @@ -49,21 +49,21 @@ public class XWListActivity extends ListActivity { @Override protected void onResume() { - Utils.logf( "%s.onResume(this=%x)", getClass().getName(), this ); + Utils.logf( "%s.onResume(this=%H)", getClass().getName(), this ); super.onResume(); } @Override protected void onPause() { - Utils.logf( "%s.onPause(this=%x)", getClass().getName(), this ); + Utils.logf( "%s.onPause(this=%H)", getClass().getName(), this ); super.onPause(); } @Override protected void onStop() { - Utils.logf( "%s.onStop(this=%x)", getClass().getName(), this ); + Utils.logf( "%s.onStop(this=%H)", getClass().getName(), this ); DispatchNotify.ClearRunning( this ); super.onStop(); } @@ -71,8 +71,8 @@ public class XWListActivity extends ListActivity { @Override protected void onDestroy() { - Utils.logf( "%s.onDestroy(this=%x); isFinishing=%s", - getClass().getName(), this, isFinishing()?"true":"false" ); + Utils.logf( "%s.onDestroy(this=%H); isFinishing=%b", + getClass().getName(), this, isFinishing() ); super.onDestroy(); }