fix invite-how alert not scrolling

By setting a custom view I wasn't using I broke scrolling of the
AlertDialog's list view which I was using. Known bug apparently....

xwords4/android/app/src/main/java/org/eehouse/android/xw4/ConfirmThenAlert.java

@@ -41,9 +41,9 @@ public class ConfirmThenAlert extends DlgDelegateAlert {
 
     @Override
     public void populateBuilder( Context context, DlgState state,
-                                 AlertDialog.Builder builder,
+                                 AlertDialog.Builder builder )
-                                 NotAgainView naView )
     {
+        NotAgainView naView = addNAView( state, builder );
         OnClickListener lstnr = mkCallbackClickListener( naView );
 
         builder.setTitle( state.m_titleId == 0 ? R.string.query_title : state.m_titleId )

xwords4/android/app/src/main/java/org/eehouse/android/xw4/DlgDelegateAlert.java

@@ -64,27 +64,32 @@ abstract class DlgDelegateAlert extends XWDialogFragment {
     }
 
     abstract void populateBuilder( Context context, DlgState state,
-                                   AlertDialog.Builder builder,
+                                   AlertDialog.Builder builder );
-                                   NotAgainView naView );
 
     Dialog create( AlertDialog.Builder builder ) { return builder.create(); }
 
+    protected NotAgainView addNAView( DlgState state, AlertDialog.Builder builder )
+    {
+        Context context = getActivity();
+        NotAgainView naView =
+            ((NotAgainView)LocUtils.inflate( context, R.layout.not_again_view ))
+            .setMessage( state.m_msg )
+            .setShowNACheckbox( 0 != state.m_prefsNAKey );
+
+        builder.setView( naView );
+
+        return naView;
+    }
+
     @Override
     public final Dialog onCreateDialog( Bundle sis )
     {
         Context context = getActivity();
         DlgState state = getState( sis );
 
-        NotAgainView naView =
+        AlertDialog.Builder builder = LocUtils.makeAlertBuilder( context );
-            ((NotAgainView)LocUtils.inflate( context, R.layout.not_again_view ))
-            .setMessage( state.m_msg )
-            .setShowNACheckbox( 0 != state.m_prefsNAKey );
 
-        AlertDialog.Builder builder = LocUtils.makeAlertBuilder( context )
+        populateBuilder( context, state, builder );
-            .setView( naView )
-            ;
-
-        populateBuilder( context, state, builder, naView );
 
         return create( builder );
     }

xwords4/android/app/src/main/java/org/eehouse/android/xw4/EnableSMSAlert.java

@@ -47,8 +47,7 @@ public class EnableSMSAlert extends DlgDelegateAlert {
 
     @Override
     public void populateBuilder( Context context, final DlgState state,
-                                 AlertDialog.Builder builder,
+                                 AlertDialog.Builder builder )
-                                 NotAgainView naView )
     {
         View layout = LocUtils.inflate( context, R.layout.confirm_sms );
         mSpinner = (Spinner)layout.findViewById( R.id.confirm_sms_reasons );

xwords4/android/app/src/main/java/org/eehouse/android/xw4/InviteChoicesAlert.java

@@ -35,7 +35,6 @@ import java.util.List;
 import org.eehouse.android.xw4.DBUtils.SentInvitesInfo;
 import org.eehouse.android.xw4.DlgDelegate.Action;
 import org.eehouse.android.xw4.DlgDelegate.ActionPair;
-import org.eehouse.android.xw4.DlgDelegate.ConfirmThenBuilder;
 import org.eehouse.android.xw4.DlgDelegate.DlgClickNotify.InviteMeans;
 import org.eehouse.android.xw4.DlgDelegate.NotAgainBuilder;
 import org.eehouse.android.xw4.Perms23.Perm;
@@ -54,8 +53,7 @@ public class InviteChoicesAlert extends DlgDelegateAlert {
 
     @Override
     public void populateBuilder( final Context context, final DlgState state,
-                                 AlertDialog.Builder builder,
+                                 AlertDialog.Builder builder )
-                                 NotAgainView naView )
     {
         final ArrayList<InviteMeans> means =
             new ArrayList<InviteMeans>();

xwords4/android/app/src/main/java/org/eehouse/android/xw4/NotAgainAlert.java

@@ -47,9 +47,9 @@ public class NotAgainAlert extends DlgDelegateAlert {
 
     @Override
     public void populateBuilder( Context context, DlgState state,
-                                 AlertDialog.Builder builder,
+                                 AlertDialog.Builder builder )
-                                 NotAgainView naView )
     {
+        NotAgainView naView = addNAView( state, builder );
         builder.setTitle( R.string.newbie_title )
             .setPositiveButton( android.R.string.ok,
                                 mkCallbackClickListener( naView ) );

xwords4/android/app/src/main/java/org/eehouse/android/xw4/OkOnlyAlert.java

@@ -47,8 +47,7 @@ public class OkOnlyAlert extends DlgDelegateAlert {
 
     @Override
     public void populateBuilder( Context context, DlgState state,
-                                 AlertDialog.Builder builder,
+                                 AlertDialog.Builder builder )
-                                 NotAgainView naView )
     {
         builder.setTitle( state.m_titleId == 0 ? R.string.info_title : state.m_titleId )
             .setPositiveButton( android.R.string.ok, null )