Miroirs/xwords
1
0
Fork 0
mirror of git://xwords.git.sourceforge.net/gitroot/xwords/xwords synced 2024-12-28 09:58:30 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

make all APIs private and add as friends the safe classes that will

Browse source 
access them.  This should allow reduction in the locking within cref
instances since only one thread at a time will be permitted inside by
SafeCref.
This commit is contained in:
ehouse 2005-09-03 15:59:48 +00:00
parent 56454d734b
commit 117f22d374
1 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
relay/cref.h
View file

@ -45,19 +45,27 @@ class HostRec {
class CookieRef {
public:
private:
/* These classes have access to CookieRef. All others should go through
SafeCref instances. */
friend class CRefMgr;
friend class SafeCref;
friend class CookieMapIterator;
CookieRef( string s, CookieID id );
~CookieRef();
/* Within this cookie, remember that this hostID and socket go together.
If the hostID is HOST_ID_SERVER, it's the server. */
short GetHeartbeat() { return m_heatbeat; }
CookieID GetCookieID() { return m_connectionID; }
int HostKnown( HostID host ) { return -1 != SocketForHost( host ); }
int CountSockets() { return m_hostSockets.size(); }
int HasSocket( int socket );
string Name() { return m_name; }
short GetHeartbeat() { return m_heatbeat; }
int SocketForHost( HostID dest );
int NotFullyConnected() { return m_curState != XW_ST_ALLCONNECTED; }
/* for console */
@ -70,7 +78,6 @@ class CookieRef {
static void Delete( CookieID id );
static void Delete( const char* name );
/* These need to become private */
void _Connect( int socket, HostID srcID );
void _Reconnect( int socket, HostID srcID );
void _HandleHeartbeat( HostID id, int socket );
@ -81,8 +88,6 @@ class CookieRef {
int ShouldDie() { return m_curState == XW_ST_DEAD; }
private:
typedef struct CRefEvent {
XW_RELAY_EVENT type;
union {
@ -122,11 +127,6 @@ class CookieRef {
} u;
} CRefEvent;
friend class CRefMgr;
CookieRef( string s, CookieID id );
int SocketForHost( HostID dest );
void send_with_length( int socket, unsigned char* buf, int bufLen );
void RecordSent( int nBytes, int socket ) {
m_totalSent += nBytes;