From 0f8e55a260846cb1a9e19f174b6e7c4f46e56969 Mon Sep 17 00:00:00 2001
From: Eric House <xwords@eehouse.org>
Date: Tue, 12 Feb 2019 07:47:57 -0800
Subject: [PATCH] put GameOver view layout into a ScrollView

When device in landscape the archive box is otherwise unreachable on a
four-player game
---
 .../eehouse/android/xw4/GameOverAlert.java    |  6 +--
 .../app/src/main/res/layout/game_over.xml     | 50 +++++++++++--------
 2 files changed, 31 insertions(+), 25 deletions(-)

diff --git a/xwords4/android/app/src/main/java/org/eehouse/android/xw4/GameOverAlert.java b/xwords4/android/app/src/main/java/org/eehouse/android/xw4/GameOverAlert.java
index 4c0f1cf2f..9331a324f 100644
--- a/xwords4/android/app/src/main/java/org/eehouse/android/xw4/GameOverAlert.java
+++ b/xwords4/android/app/src/main/java/org/eehouse/android/xw4/GameOverAlert.java
@@ -26,10 +26,10 @@ import android.app.Dialog;
 import android.content.DialogInterface;
 import android.os.Bundle;
 import android.view.View;
+import android.view.ViewGroup;
 import android.widget.Button;
 import android.widget.CheckBox;
 import android.widget.CompoundButton;
-import android.widget.LinearLayout;
 import android.widget.TextView;
 
 import org.eehouse.android.xw4.DlgDelegate.Action;
@@ -49,7 +49,7 @@ public class GameOverAlert extends XWDialogFragment
     private GameSummary mSummary;
     private int mTitleID;
     private String mMsg;
-    private LinearLayout m_view;
+    private ViewGroup m_view;
     private boolean mInArchive;
     private CheckBox mArchiveBox;
     // private boolean mArchiveChecked;
@@ -95,7 +95,7 @@ public class GameOverAlert extends XWDialogFragment
         mInArchive = sis.getBoolean( IN_ARCH );
 
         Activity activity = getActivity();
-        m_view = (LinearLayout)LocUtils.inflate( activity, R.layout.game_over );
+        m_view = (ViewGroup)LocUtils.inflate( activity, R.layout.game_over );
         initView();
 
         AlertDialog.Builder ab = LocUtils.makeAlertBuilder( activity )
diff --git a/xwords4/android/app/src/main/res/layout/game_over.xml b/xwords4/android/app/src/main/res/layout/game_over.xml
index 7739fd160..167fde61a 100644
--- a/xwords4/android/app/src/main/res/layout/game_over.xml
+++ b/xwords4/android/app/src/main/res/layout/game_over.xml
@@ -1,24 +1,30 @@
 <?xml version="1.0" encoding="utf-8"?>
 
-<LinearLayout
-    xmlns:android="http://schemas.android.com/apk/res/android"
-    android:orientation="vertical"
-    android:layout_width="fill_parent" 
-    android:layout_height="fill_parent"
-    android:padding="10dp"
-    >
-  <TextView android:id="@+id/msg"
-            android:layout_width="match_parent"
-            android:layout_height="wrap_content"
-            android:textAppearance="?android:attr/textAppearanceMedium"
-            />
-  <!-- spacer -->
-  <View android:layout_height="15dp"
-        android:layout_width="match_parent"
-        />
-  <CheckBox android:id="@+id/archive_check"
-            android:layout_width="wrap_content" 
-            android:layout_height="wrap_content"
-            android:text="@string/button_archive" 
-            />
-</LinearLayout>
+<ScrollView xmlns:android="http://schemas.android.com/apk/res/android"
+            android:layout_width="fill_parent"
+            android:layout_height="fill_parent"
+            android:orientation="vertical"
+            >
+  <LinearLayout
+      xmlns:android="http://schemas.android.com/apk/res/android"
+      android:orientation="vertical"
+      android:layout_width="fill_parent"
+      android:layout_height="fill_parent"
+      android:padding="10dp"
+      >
+    <TextView android:id="@+id/msg"
+              android:layout_width="match_parent"
+              android:layout_height="wrap_content"
+              android:textAppearance="?android:attr/textAppearanceMedium"
+              />
+    <!-- spacer -->
+    <View android:layout_height="15dp"
+          android:layout_width="match_parent"
+          />
+    <CheckBox android:id="@+id/archive_check"
+              android:layout_width="wrap_content"
+              android:layout_height="wrap_content"
+              android:text="@string/button_archive"
+              />
+  </LinearLayout>
+</ScrollView>