mirror of
https://github.com/NickHu/sway
synced 2024-12-29 22:23:46 +01:00
5fb5984e94
Prior to this patch, if I ran something like this, sway would crash:
swaymsg bar height 50
or
swaymsg bar not-a-bar-id color bg #ff0000
This was in contrast to other bar subcommands, like status_command,
which would exit with a "No bar defined" message.
The difference between the subcommands that crashed and the ones that
exited was that some subcommands had a check to see if a bar was
specified, while others just assumed that it had been and carried on
until they segfaulted.
Because this check was identical in every subcommand it was present in,
and I couldn't think of a case where it would be valid to run a bar
subcommand without specifying which bar to apply it to, I moved this
check from individual subcommands into the bar command, which is already
responsible for actually setting the specified bar. This reduced code
duplication, and fixed the crash for the subcommands that were missing
this check.
28 lines
779 B
C
28 lines
779 B
C
#include <string.h>
|
|
#include "sway/commands.h"
|
|
#include "log.h"
|
|
#include "stringop.h"
|
|
|
|
struct cmd_results *bar_cmd_status_command(int argc, char **argv) {
|
|
struct cmd_results *error = NULL;
|
|
if ((error = checkarg(argc, "status_command", EXPECTED_AT_LEAST, 1))) {
|
|
return error;
|
|
}
|
|
free(config->current_bar->status_command);
|
|
config->current_bar->status_command = NULL;
|
|
|
|
char *new_command = join_args(argv, argc);
|
|
if (strcmp(new_command, "-") != 0) {
|
|
config->current_bar->status_command = new_command;
|
|
sway_log(SWAY_DEBUG, "Feeding bar with status command: %s",
|
|
config->current_bar->status_command);
|
|
} else {
|
|
free(new_command);
|
|
}
|
|
|
|
if (config->active && !config->validating) {
|
|
load_swaybar(config->current_bar);
|
|
}
|
|
|
|
return cmd_results_new(CMD_SUCCESS, NULL);
|
|
}
|