sway-patched-tray-menu-github/sway
Paul Riou b5cc11b226 criteria: fix crash when comparing NULL properties
For each following combinations of criteria & command below, the command would
crash sway without the fix.
It's particular about the __focused__ criteria, where the view matches part of
the criteria but not the focused app, leading to a failure when calling
`strcmp` with NULL.

"xterm" is a non-wayland app (X11) and "kitty" is. Both are terminals.

    # "class" is specific to X11
    # The view is X11 (xterm) leading to the criteria checking for the
    # focused app's class, leading to a crash
    for_window [class="__focused__"] floating enable
    exec kitty -e xterm

    # Similarly, crash as the focused app (xterm) has no app_id when the view has one
    for_window [app_id="__focused__"] floating enable
    exec xterm -e kitty

    # If the view has a title but not the focused app: NULL title will crash criteria checking
    for_window [title="__focused__"] floating enable
    exec xterm -title "" -e xterm
2020-12-04 10:49:49 +01:00
..
commands tree/container: introduce container_is_sticky[_or_child] functions 2020-11-11 20:43:58 -05:00
config hide_cursor: Add an option to hide when typing 2020-10-30 09:59:54 +01:00
desktop xdg_shell: allow views to change geometry anytime 2020-11-24 09:47:23 +01:00
input input/keyboard: fix Group# bindings for keyboard groups 2020-11-12 10:52:45 +01:00
tree tree/container: introduce container_is_sticky[_or_child] functions 2020-11-11 20:43:58 -05:00
commands.c commands: disallow runtime include 2020-07-27 10:54:04 +02:00
config.c Reload command now matches i3's implementation 2020-07-07 17:15:57 -04:00
criteria.c criteria: fix crash when comparing NULL properties 2020-12-04 10:49:49 +01:00
decoration.c Fix double free when unmapping any view 2018-11-15 15:22:09 +10:00
ipc-json.c Add support for workspace_min_width bar option. 2020-10-11 19:12:42 +02:00
ipc-server.c Fix incorrect format specifiers 2020-07-30 22:02:42 -04:00
main.c Handle SIGINT 2020-08-11 18:37:11 -04:00
meson.build input/tablet: add tool_mode option to set tablet tools as relative input 2020-10-12 15:01:37 +02:00
server.c server: Avoid using "wayland-0" as WAYLAND_DISPLAY 2020-09-16 00:14:20 +02:00
sway-bar.5.scd Add support for workspace_min_width bar option. 2020-10-11 19:12:42 +02:00
sway-input.5.scd hide_cursor: Add an option to hide when typing 2020-10-30 09:59:54 +01:00
sway-ipc.7.scd document parse_error 2020-11-21 11:42:29 +01:00
sway-output.5.scd Simplify repaint scheduling documentation 2020-05-11 10:36:33 +02:00
sway.1.scd add dots to man 2020-04-14 10:10:35 +02:00
sway.5.scd document force_display_urgency_hint 2020-08-03 15:39:48 +02:00
swaynag.c Rename symbol set_cloexec to sway_set_cloexec, remove duplicates. 2019-11-01 12:41:08 -04:00
xdg_decoration.c Fix xdg-decoration unconfigured if set before first commit 2019-05-03 15:37:32 -06:00