mirror of
https://github.com/gwenhael-le-moine/sway-patched-tray-menu.git
synced 2024-12-27 21:58:16 +01:00
89afb761ba
If output_cmd_background is given a valid mode as the first argument, then there is no file given and an error should be returned. join_args should not be called with an argc of zero since it sets the last character to the null terminator. With an argc of zero, the length is zero causing a heap buffer overflow when setting the byte before the start of argv to '\0'. This probably will not ever generate a segfault, but may cause data corruption to whatever is directly before it in memory. To make other such cases easier to detect, this also adds a sway_assert in join_args when argc is zero.
147 lines
3.6 KiB
C
147 lines
3.6 KiB
C
#define _POSIX_C_SOURCE 200809L
|
|
#include <libgen.h>
|
|
#include <stdio.h>
|
|
#include <string.h>
|
|
#include <strings.h>
|
|
#include <unistd.h>
|
|
#include <wordexp.h>
|
|
#include <errno.h>
|
|
#include "sway/commands.h"
|
|
#include "sway/config.h"
|
|
#include "sway/swaynag.h"
|
|
#include "log.h"
|
|
#include "stringop.h"
|
|
|
|
static const char *bg_options[] = {
|
|
"stretch",
|
|
"center",
|
|
"fill",
|
|
"fit",
|
|
"tile",
|
|
};
|
|
|
|
struct cmd_results *output_cmd_background(int argc, char **argv) {
|
|
if (!config->handler_context.output_config) {
|
|
return cmd_results_new(CMD_FAILURE, "Missing output config");
|
|
}
|
|
if (!argc) {
|
|
return cmd_results_new(CMD_INVALID,
|
|
"Missing background file or color specification.");
|
|
}
|
|
if (argc < 2) {
|
|
return cmd_results_new(CMD_INVALID,
|
|
"Missing background scaling mode or `solid_color`.");
|
|
}
|
|
|
|
struct output_config *output = config->handler_context.output_config;
|
|
|
|
if (strcasecmp(argv[1], "solid_color") == 0) {
|
|
output->background = strdup(argv[0]);
|
|
output->background_option = strdup("solid_color");
|
|
output->background_fallback = NULL;
|
|
argc -= 2; argv += 2;
|
|
} else {
|
|
bool valid = false;
|
|
char *mode;
|
|
size_t j;
|
|
for (j = 0; j < (size_t)argc; ++j) {
|
|
mode = argv[j];
|
|
size_t n = sizeof(bg_options) / sizeof(char *);
|
|
for (size_t k = 0; k < n; ++k) {
|
|
if (strcasecmp(mode, bg_options[k]) == 0) {
|
|
valid = true;
|
|
break;
|
|
}
|
|
}
|
|
if (valid) {
|
|
break;
|
|
}
|
|
}
|
|
if (!valid) {
|
|
return cmd_results_new(CMD_INVALID,
|
|
"Missing background scaling mode.");
|
|
}
|
|
if (j == 0) {
|
|
return cmd_results_new(CMD_INVALID, "Missing background file");
|
|
}
|
|
|
|
wordexp_t p = {0};
|
|
char *src = join_args(argv, j);
|
|
while (strstr(src, " ")) {
|
|
src = realloc(src, strlen(src) + 2);
|
|
char *ptr = strstr(src, " ") + 1;
|
|
memmove(ptr + 1, ptr, strlen(ptr) + 1);
|
|
*ptr = '\\';
|
|
}
|
|
if (wordexp(src, &p, 0) != 0 || p.we_wordv[0] == NULL) {
|
|
struct cmd_results *cmd_res = cmd_results_new(CMD_INVALID,
|
|
"Invalid syntax (%s)", src);
|
|
free(src);
|
|
wordfree(&p);
|
|
return cmd_res;
|
|
}
|
|
free(src);
|
|
src = join_args(p.we_wordv, p.we_wordc);
|
|
wordfree(&p);
|
|
if (!src) {
|
|
sway_log(SWAY_ERROR, "Failed to duplicate string");
|
|
return cmd_results_new(CMD_FAILURE, "Unable to allocate resource");
|
|
}
|
|
|
|
if (config->reading && *src != '/') {
|
|
// src file is inside configuration dir
|
|
|
|
char *conf = strdup(config->current_config_path);
|
|
if (!conf) {
|
|
sway_log(SWAY_ERROR, "Failed to duplicate string");
|
|
free(src);
|
|
return cmd_results_new(CMD_FAILURE,
|
|
"Unable to allocate resources");
|
|
}
|
|
|
|
char *conf_path = dirname(conf);
|
|
char *rel_path = src;
|
|
src = malloc(strlen(conf_path) + strlen(src) + 2);
|
|
if (!src) {
|
|
free(rel_path);
|
|
free(conf);
|
|
sway_log(SWAY_ERROR, "Unable to allocate memory");
|
|
return cmd_results_new(CMD_FAILURE,
|
|
"Unable to allocate resources");
|
|
}
|
|
|
|
sprintf(src, "%s/%s", conf_path, rel_path);
|
|
free(rel_path);
|
|
free(conf);
|
|
}
|
|
|
|
bool can_access = access(src, F_OK) != -1;
|
|
if (!can_access) {
|
|
sway_log_errno(SWAY_ERROR, "Unable to access background file '%s'",
|
|
src);
|
|
config_add_swaynag_warning("Unable to access background file '%s'",
|
|
src);
|
|
free(src);
|
|
} else {
|
|
output->background = src;
|
|
output->background_option = strdup(mode);
|
|
}
|
|
argc -= j + 1; argv += j + 1;
|
|
|
|
output->background_fallback = NULL;
|
|
if (argc && *argv[0] == '#') {
|
|
output->background_fallback = strdup(argv[0]);
|
|
argc--; argv++;
|
|
|
|
if (!can_access) {
|
|
output->background = output->background_fallback;
|
|
output->background_option = strdup("solid_color");
|
|
output->background_fallback = NULL;
|
|
}
|
|
}
|
|
}
|
|
|
|
config->handler_context.leftovers.argc = argc;
|
|
config->handler_context.leftovers.argv = argv;
|
|
return NULL;
|
|
}
|