mirror of
git://slackware.nl/current.git
synced 2024-12-31 10:28:29 +01:00
2559feca78
patches/packages/xorg-server-1.20.14-x86_64-4_slack15.0.txz: Rebuilt.
xkb: proof GetCountedString against request length attacks.
xkb: fix some possible memleaks in XkbGetKbdByName.
xquartz: Fix a possible crash when editing the Application menu due
to mutating immutable arrays.
For more information, see:
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-3550
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-3551
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-3553
(* Security fix *)
patches/packages/xorg-server-xephyr-1.20.14-x86_64-4_slack15.0.txz: Rebuilt.
patches/packages/xorg-server-xnest-1.20.14-x86_64-4_slack15.0.txz: Rebuilt.
patches/packages/xorg-server-xvfb-1.20.14-x86_64-4_slack15.0.txz: Rebuilt.
patches/packages/xorg-server-xwayland-21.1.4-x86_64-3_slack15.0.txz: Rebuilt.
xkb: proof GetCountedString against request length attacks.
xkb: fix some possible memleaks in XkbGetKbdByName.
For more information, see:
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-3550
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-3551
(* Security fix *)
59 lines
2 KiB
Diff
59 lines
2 KiB
Diff
From 18f91b950e22c2a342a4fbc55e9ddf7534a707d2 Mon Sep 17 00:00:00 2001
|
|
From: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Date: Wed, 13 Jul 2022 11:23:09 +1000
|
|
Subject: xkb: fix some possible memleaks in XkbGetKbdByName
|
|
|
|
GetComponentByName returns an allocated string, so let's free that if we
|
|
fail somewhere.
|
|
|
|
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
---
|
|
xkb/xkb.c | 26 ++++++++++++++++++++------
|
|
1 file changed, 20 insertions(+), 6 deletions(-)
|
|
|
|
diff --git a/xkb/xkb.c b/xkb/xkb.c
|
|
index 4692895db..b79a269e3 100644
|
|
--- a/xkb/xkb.c
|
|
+++ b/xkb/xkb.c
|
|
@@ -5935,18 +5935,32 @@ ProcXkbGetKbdByName(ClientPtr client)
|
|
xkb = dev->key->xkbInfo->desc;
|
|
status = Success;
|
|
str = (unsigned char *) &stuff[1];
|
|
- if (GetComponentSpec(&str, TRUE, &status)) /* keymap, unsupported */
|
|
- return BadMatch;
|
|
+ {
|
|
+ char *keymap = GetComponentSpec(&str, TRUE, &status); /* keymap, unsupported */
|
|
+ if (keymap) {
|
|
+ free(keymap);
|
|
+ return BadMatch;
|
|
+ }
|
|
+ }
|
|
names.keycodes = GetComponentSpec(&str, TRUE, &status);
|
|
names.types = GetComponentSpec(&str, TRUE, &status);
|
|
names.compat = GetComponentSpec(&str, TRUE, &status);
|
|
names.symbols = GetComponentSpec(&str, TRUE, &status);
|
|
names.geometry = GetComponentSpec(&str, TRUE, &status);
|
|
- if (status != Success)
|
|
+ if (status == Success) {
|
|
+ len = str - ((unsigned char *) stuff);
|
|
+ if ((XkbPaddedSize(len) / 4) != stuff->length)
|
|
+ status = BadLength;
|
|
+ }
|
|
+
|
|
+ if (status != Success) {
|
|
+ free(names.keycodes);
|
|
+ free(names.types);
|
|
+ free(names.compat);
|
|
+ free(names.symbols);
|
|
+ free(names.geometry);
|
|
return status;
|
|
- len = str - ((unsigned char *) stuff);
|
|
- if ((XkbPaddedSize(len) / 4) != stuff->length)
|
|
- return BadLength;
|
|
+ }
|
|
|
|
CHK_MASK_LEGAL(0x01, stuff->want, XkbGBN_AllComponentsMask);
|
|
CHK_MASK_LEGAL(0x02, stuff->need, XkbGBN_AllComponentsMask);
|
|
--
|
|
cgit v1.2.1
|
|
|