slackbuilds_ponce/network/pptpd/pptpctl_fix.patch
Swaz 51d4ea72f7 network/pptpd: Fixed invalid declaration of pppInterfaceIPs
> Hi, have been testing pptpd on slackware 14.0RC4 using your
> slackbuild, and found there was a corruption in arguments
> being passed to pppd.
>
> had spent a lot of time searching for a fix, but found none.
> many others had mentioned the problem, but not a fix.
>
> the attached patch fixed the issue (have posted to the poptop
> mailing list)
>
> seems to be a compiler issue around the declaration of
> char pppInterfaceIPs[33];
> inside the if { } no longer being valid outside of the statement.
> and hence being corrupted when referred to when pppd is invoked.

Signed-off-by: Robby Workman <rworkman@slackbuilds.org>
2012-09-14 16:40:34 -05:00

13 lines
541 B
Diff

diff -rupN pptpd-1.3.4/pptpctrl.c pptpd-1.3.4.new/pptpctrl.c
--- pptpd-1.3.4/pptpctrl.c 2006-12-08 13:01:40.000000000 +1300
+++ pptpd-1.3.4.new/pptpctrl.c 2012-09-14 11:16:38.646659399 +1200
@@ -759,8 +759,8 @@ static void launch_pppd(char **pppaddrs,
syslog(LOG_DEBUG, "CTRL (PPPD Launcher): remote address = %s", pppaddrs[1]);
}
+ char pppInterfaceIPs[33];
if (*pppaddrs[0] || *pppaddrs[1]) {
- char pppInterfaceIPs[33];
sprintf(pppInterfaceIPs, "%s:%s", pppaddrs[0], pppaddrs[1]);
pppd_argv[an++] = pppInterfaceIPs;
}