sp0250: make drq_r return an int instead of u8

This commit is contained in:
hap 2023-07-26 01:37:14 +02:00
parent 5bfad7e877
commit a4e202ae77
5 changed files with 4 additions and 17 deletions

View file

@ -181,7 +181,7 @@ void sp0250_device::write(uint8_t data)
} }
uint8_t sp0250_device::drq_r() int sp0250_device::drq_r()
{ {
m_stream->update(); m_stream->update();
return (m_fifo_pos == 15) ? CLEAR_LINE : ASSERT_LINE; return (m_fifo_pos == 15) ? CLEAR_LINE : ASSERT_LINE;

View file

@ -14,7 +14,7 @@ public:
void set_pwm_mode() { m_pwm_mode = true; } void set_pwm_mode() { m_pwm_mode = true; }
void write(uint8_t data); void write(uint8_t data);
uint8_t drq_r(); int drq_r();
protected: protected:
// device-level overrides // device-level overrides

View file

@ -504,17 +504,6 @@ gottlieb_sound_r2_device::gottlieb_sound_r2_device(const machine_config &mconfig
} }
//-------------------------------------------------
// speech_drq_custom_r - return the SP0250
// request line as an input port bit
//-------------------------------------------------
CUSTOM_INPUT_MEMBER(gottlieb_sound_r2_device::speech_drq_custom_r)
{
return m_sp0250->drq_r();
}
//------------------------------------------------- //-------------------------------------------------
// speech_control_w - primary audio control // speech_control_w - primary audio control
// register on the speech board // register on the speech board
@ -623,7 +612,7 @@ INPUT_PORTS_START( gottlieb_sound_r2 )
PORT_DIPNAME( 0x40, 0x40, "Sound Test" ) PORT_DIPLOCATION("SB2:3") PORT_DIPNAME( 0x40, 0x40, "Sound Test" ) PORT_DIPLOCATION("SB2:3")
PORT_DIPSETTING( 0x40, DEF_STR( Off ) ) PORT_DIPSETTING( 0x40, DEF_STR( Off ) )
PORT_DIPSETTING( 0x00, DEF_STR( On ) ) PORT_DIPSETTING( 0x00, DEF_STR( On ) )
PORT_BIT( 0x80, IP_ACTIVE_HIGH, IPT_CUSTOM ) PORT_CUSTOM_MEMBER(gottlieb_sound_r2_device, speech_drq_custom_r) PORT_BIT( 0x80, IP_ACTIVE_HIGH, IPT_CUSTOM ) PORT_READ_LINE_DEVICE_MEMBER("spsnd", sp0250_device, drq_r)
INPUT_PORTS_END INPUT_PORTS_END
ioport_constructor gottlieb_sound_r2_device::device_input_ports() const ioport_constructor gottlieb_sound_r2_device::device_input_ports() const

View file

@ -233,8 +233,6 @@ public:
// configuration helpers // configuration helpers
void enable_cobram3_mods() { m_cobram3_mod = true; } void enable_cobram3_mods() { m_cobram3_mod = true; }
CUSTOM_INPUT_MEMBER(speech_drq_custom_r);
protected: protected:
// device-level overrides // device-level overrides
virtual void device_add_mconfig(machine_config &config) override; virtual void device_add_mconfig(machine_config &config) override;