Miroirs/leocad
1
0
Fork 0
mirror of https://github.com/leozide/leocad synced 2024-11-16 07:47:27 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

More user friendly errors for --camera-position.
Some checks failed
LeoCAD CI / build-ubuntu (push) Has been cancelled
Details
LeoCAD CI / build-macos (push) Has been cancelled
Details

Browse source
This commit is contained in:
Leonardo Zide 2024-10-15 11:46:42 -07:00
parent 5772688318
commit 9edd8f95ed
1 changed files with 19 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
common/lc_application.cpp
View file

@ -614,19 +614,30 @@ lcCommandLineOptions lcApplication::ParseCommandLineOptions()
{
if ((Options.SetCameraPosition = ParseFloatArray(9, Options.CameraPosition[0], true)))
{
lcVector3 Front = Options.CameraPosition[1] - Options.CameraPosition[0];
if (Front.LengthSquared() < 1.0f || Options.CameraPosition[2].LengthSquared() < 1.0f || fabsf(lcDot(lcNormalize(Front), lcNormalize(Options.CameraPosition[2]))) > 0.99f)
{
Options.StdErr += tr("Invalid parameter value(s) specified for the '%1' option.\n").arg(Option);
Options.ParseOK = false;
}
else if (Option == QLatin1String("--camera-position-ldraw"))
if (Option == QLatin1String("--camera-position-ldraw"))
{
Options.CameraPosition[0] = lcVector3LDrawToLeoCAD(Options.CameraPosition[0]);
Options.CameraPosition[1] = lcVector3LDrawToLeoCAD(Options.CameraPosition[1]);
Options.CameraPosition[2] = lcVector3LDrawToLeoCAD(Options.CameraPosition[2]);
}
lcVector3 Front = Options.CameraPosition[1] - Options.CameraPosition[0];
if (Front.LengthSquared() < 0.1f)
{
Options.StdErr += tr("The camera position is too close to the camera target of the '%1' option.\n").arg(Option);
Options.ParseOK = false;
}
else if (Options.CameraPosition[2].LengthSquared() < 0.1f)
{
Options.StdErr += tr("Invalid up vector length specified for the '%1' option.\n").arg(Option);
Options.ParseOK = false;
}
else if (fabsf(lcDot(lcNormalize(Front), lcNormalize(Options.CameraPosition[2]))) > 0.99f)
{
Options.StdErr += tr("The up vector is parallel to the front vector specified for the '%1' option.\n").arg(Option);
Options.ParseOK = false;
}
}
}
else if (Option == QLatin1String("--orthographic"))