From add8a7d6c3ca3c2d7775188af7bfd005cd39102b Mon Sep 17 00:00:00 2001
From: facundoolano <facundo.olano@gmail.com>
Date: Sun, 25 Feb 2024 11:35:08 -0300
Subject: [PATCH] fix xml_escape filter

---
 templates/filters.go | 26 ++++++++++++--------------
 1 file changed, 12 insertions(+), 14 deletions(-)

diff --git a/templates/filters.go b/templates/filters.go
index 3fd1c93..2d23b3c 100644
--- a/templates/filters.go
+++ b/templates/filters.go
@@ -3,7 +3,6 @@ package templates
 import (
 	"bytes"
 	"fmt"
-	"log"
 	"net/url"
 	"path/filepath"
 	"reflect"
@@ -33,29 +32,28 @@ func loadJekyllFilters(e *liquid.Engine, siteUrl string, includesDir string) {
 	e.RegisterFilter("keys", keysFilter)
 	e.RegisterFilter("where", whereFilter)
 	e.RegisterFilter("where_exp", whereExpFilter)
-	e.RegisterFilter("xml_escape", xml.Marshal)
 
 	e.RegisterFilter("normalize_whitespace", func(s string) string {
 		wsPattern := regexp.MustCompile(`(?s:[\s\n]+)`)
 		return wsPattern.ReplaceAllString(s, " ")
 	})
 
-	e.RegisterFilter("markdownify", func(s string) string {
-		// using goldmark here instead of balckfriday, to avoid an extra dependencie
+	e.RegisterFilter("markdownify", func(s string) (string, error) {
+		// using goldmark here instead of balckfriday, to avoid an extra dependency
 		var buf bytes.Buffer
 		err := goldmark.Convert([]byte(s), &buf)
-		if err != nil {
-			log.Fatal(err)
-		}
-		return buf.String()
+		return buf.String(), err
 	})
 
-	e.RegisterFilter("absolute_url", func(path string) string {
-		url, err := url.JoinPath(siteUrl, path)
-		if err != nil {
-			log.Fatal(err)
-		}
-		return url
+	e.RegisterFilter("xml_escape", func(s string) (string, error) {
+		// using goldmark here instead of balckfriday, to avoid an extra dependency
+		var buf bytes.Buffer
+		err := xml.EscapeText(&buf, []byte(s))
+		return buf.String(), err
+	})
+
+	e.RegisterFilter("absolute_url", func(path string) (string, error) {
+		return url.JoinPath(siteUrl, path)
 	})
 
 	e.RegisterFilter("date_to_rfc822", func(date time.Time) string {