Topping: do not assign an empty move to the player immediately.

It is now done only after a timeout, to avoid the need to replace
this empty move when the player finds a top move.

game/arbitration.cpp

@@ -51,7 +51,7 @@ void Arbitration::setRackRandom()
 
     const PlayedRack &newRack =
         helperSetRackRandom(getHistory().getCurrentRack(), true, RACK_NEW);
-    setGameAndPlayersRack(newRack);
+    setGameAndPlayersRack(newRack, true);
 }
 
 
@@ -68,7 +68,7 @@ void Arbitration::setRackManual(const wstring &iLetters)
     // As a result, we simply make all the letters uppercase
     const wstring &upperLetters = toUpper(iLetters);
     const PlayedRack &newRack = helperSetRackManual(false, upperLetters);
-    setGameAndPlayersRack(newRack);
+    setGameAndPlayersRack(newRack, true);
 }
 
 

game/duplicate.cpp

@@ -132,12 +132,12 @@ void Duplicate::start()
 
         bool fillRacks = Settings::Instance().getBool("arbitration.fill-rack");
         if (isArbitrationGame() && !fillRacks && !hasMasterGame())
-            setGameAndPlayersRack(getHistory().getCurrentRack());
+            setGameAndPlayersRack(getHistory().getCurrentRack(), true);
         else
         {
             const PlayedRack &newRack =
                 helperSetRackRandom(getHistory().getCurrentRack(), true, RACK_NEW);
-            setGameAndPlayersRack(newRack);
+            setGameAndPlayersRack(newRack, true);
         }
     }
     catch (EndGameException &e)

game/game.cpp

@@ -682,7 +682,7 @@ int Game::checkPlayedWord(const wstring &iCoord,
 }
 
 
-void Game::setGameAndPlayersRack(const PlayedRack &iRack)
+void Game::setGameAndPlayersRack(const PlayedRack &iRack, bool iWithNoMove)
 {
     // Set the game rack
     Command *pCmd = new GameRackCmd(*this, iRack);
@@ -695,15 +695,18 @@ void Game::setGameAndPlayersRack(const PlayedRack &iRack)
         accessNavigation().addAndExecute(pCmd);
     }
 
-    // Assign a "no move" pseudo-move to all the players.
+    if (iWithNoMove)
-    // This avoids the need to distinguish between "has not played yet"
-    // and "has played with no move".
-    // This is also practical to know at which turn the warnings, penalties
-    // and solos should be assigned.
-    BOOST_FOREACH(Player *player, m_players)
     {
-        Command *pCmd = new PlayerMoveCmd(*player, Move());
+        // Assign a "no move" pseudo-move to all the players.
-        accessNavigation().addAndExecute(pCmd);
+        // This avoids the need to distinguish between "has not played yet"
+        // and "has played with no move" in duplicate and arbitration modes.
+        // This is also practical to know at which turn the warnings, penalties
+        // and solos should be assigned.
+        BOOST_FOREACH(Player *player, m_players)
+        {
+            Command *pCmd = new PlayerMoveCmd(*player, Move());
+            accessNavigation().addAndExecute(pCmd);
+        }
     }
 }
 

game/game.h

@@ -324,7 +324,7 @@ protected:
      * Helper function to set the game rack and the players rack at the same time.
      * Shouldn't be used in free game mode.
      */
-    void setGameAndPlayersRack(const PlayedRack &iRack);
+    void setGameAndPlayersRack(const PlayedRack &iRack, bool iWithNoMove);
 
     void nextPlayer();
 

game/topping.cpp

@@ -65,7 +65,7 @@ void Topping::start()
     {
         const PlayedRack &newRack =
             helperSetRackRandom(getHistory().getCurrentRack(), true, RACK_NEW);
-        setGameAndPlayersRack(newRack);
+        setGameAndPlayersRack(newRack, false);
     }
     catch (EndGameException &e)
     {
@@ -121,13 +121,9 @@ void Topping::turnTimeOut()
 
     m_board.removeTestRound();
 
-    // Commented out, because the player already has
-    // an empty move by default
-#if 0
     // The player didn't find the move
     Command *pCmd = new PlayerMoveCmd(*m_players[m_currPlayer], Move());
     accessNavigation().addAndExecute(pCmd);
-#endif
 
     // Give a penalty to the player
     // XXX: should we give the penalty directly in the NO_MOVE move?