Miroirs/devdocs
1
0
Fork 0
mirror of https://github.com/freeCodeCamp/devdocs synced 2024-09-29 05:36:48 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Revert "Update manifest.json"

Browse source 
This reverts commit f0bf956837.
"Adds a back button to the UI"

First, minimal-ui takes up valueable screen space. We should value
the users screen space, and I believe users often install PWA's
_specifically_ to recover screen space taken by browser chrome[1]. I
know I do.

Second, devdocs already shows navigation arrows on mobile. A better
solution to a lack of back button (on desktop? where?) would be to
show those same navigation arrows there, rather than use minimal-ui.

Third, there's no rationale that I could find for this commit. No
explanation or issue linked. That's almost reason enough to revert.
Please write good commits: https://chris.beams.io/posts/git-commit/

[1] https://developer.mozilla.org/en-US/docs/Glossary/chrome
This commit is contained in:
trysten 2020-12-18 17:52:38 -06:00
parent 792183e823
commit a6140ed9ec
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
public/manifest.json
View file

@ -3,7 +3,7 @@
"short_name": "DevDocs",
"description": "API Documentation Browser",
"start_url": "/",
"display": "minimal-ui",
"display": "standalone",
"background_color": "#EEEEEE",
"icons": [
{