Miroirs/DB48X-on-DM42
1
0
Fork 0
mirror of https://github.com/c3d/DB48X-on-DM42.git synced 2024-09-28 03:20:53 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

help: Avoid slowing down when scrolling through pages of help

Browse source 
When we read a lot of help, we tend to scroll down a lot of text, and
occasionally back up a little. Allow for two screenfulls worth of
backing up.

Record the vertical offset as pixels to avoid the skips we had by
counting text lines.

Fixes: #1038

Signed-off-by: Christophe de Dinechin <christophe@dinechin.org>
This commit is contained in:
Christophe de Dinechin 2024-07-22 22:36:43 +02:00
parent 0aa93d8e21
commit a05288f272
1 changed files with 18 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
src/user_interface.cc
View file

@ -2954,12 +2954,12 @@ bool user_interface::draw_help()
font_p font = styles[style].font;
coord height = font->height();
coord x = xleft;
coord y = ytop + 2 - line * height;
coord y = ytop + 2 - line;
unicode last = '\n';
uint lastTopic = 0;
uint shown = 0;
// Pun not intended
// Pun not indented
helpfile.seek(help);
// Display until end of help
@ -2973,8 +2973,18 @@ bool user_interface::draw_help()
bool blue = false;
style_name restyle = style;
if (last == '\n' && !shown && y >= ytop)
shown = helpfile.position();
if (last == '\n' && !shown)
{
if (y >= ytop)
{
shown = helpfile.position();
}
else if (line > 0 && y < ytop - 2*LCD_H)
{
help = helpfile.position();
line = ytop + 2 - y;
}
}
while (!emit)
{
@ -3550,6 +3560,7 @@ bool user_interface::handle_help(int &key)
// Help is being shown - Special keyboard mappings
uint count = shift ? 8 : 1;
size height = HelpFont->height();
switch (key)
{
case KEY_F1:
@ -3561,9 +3572,9 @@ bool user_interface::handle_help(int &key)
case KEY_UP:
case KEY_8:
case KEY_SUB:
if (line > count)
if (line > count * height)
{
line -= count;
line -= count * height;
}
else
{
@ -3589,7 +3600,7 @@ bool user_interface::handle_help(int &key)
case KEY_DOWN:
case KEY_2:
case KEY_ADD:
line += count;
line += count * height;
repeat = true;
dirtyHelp = true;
break;